diff options
| author | Douglas Gregor <dgregor@apple.com> | 2012-12-11 18:53:07 +0000 |
|---|---|---|
| committer | Douglas Gregor <dgregor@apple.com> | 2012-12-11 18:53:07 +0000 |
| commit | 86f6cf6800fa7ea3669e057c56f3487c4da3ef46 (patch) | |
| tree | 508698c2a43e64636059d6e458e15cd486c9d559 | |
| parent | a07b59e5e9b55033239c80552094421a01b75c8a (diff) | |
Don't complain about incomplete implementations for methods that are
unavailable due to availability attributes. <rdar://problem/12798237>
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@169903 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Sema/SemaDeclObjC.cpp | 11 | ||||
| -rw-r--r-- | test/SemaObjC/incomplete-implementation.m | 4 |
2 files changed, 13 insertions, 2 deletions
diff --git a/lib/Sema/SemaDeclObjC.cpp b/lib/Sema/SemaDeclObjC.cpp index 14546deef0..64b000ee9a 100644 --- a/lib/Sema/SemaDeclObjC.cpp +++ b/lib/Sema/SemaDeclObjC.cpp @@ -1168,8 +1168,17 @@ void Sema::CheckImplementationIvars(ObjCImplementationDecl *ImpDecl, void Sema::WarnUndefinedMethod(SourceLocation ImpLoc, ObjCMethodDecl *method, bool &IncompleteImpl, unsigned DiagID) { // No point warning no definition of method which is 'unavailable'. - if (method->hasAttr<UnavailableAttr>()) + switch (method->getAvailability()) { + case AR_Available: + case AR_Deprecated: + break; + + // Don't warn about unavailable or not-yet-introduced methods. + case AR_NotYetIntroduced: + case AR_Unavailable: return; + } + if (!IncompleteImpl) { Diag(ImpLoc, diag::warn_incomplete_impl); IncompleteImpl = true; diff --git a/test/SemaObjC/incomplete-implementation.m b/test/SemaObjC/incomplete-implementation.m index 54f66efcb2..69e355cb9a 100644 --- a/test/SemaObjC/incomplete-implementation.m +++ b/test/SemaObjC/incomplete-implementation.m @@ -1,8 +1,10 @@ -// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 -fsyntax-only -verify -Wno-objc-root-class %s @interface I - Meth; // expected-note{{method definition for 'Meth' not found}} \ // expected-note{{method 'Meth' declared here}} +- unavailableMeth __attribute__((availability(macosx,unavailable))); +- unavailableMeth2 __attribute__((unavailable)); @end @implementation I // expected-warning{{incomplete implementation}} |