diff options
| author | Tanya Lattner <tonic@nondot.org> | 2013-01-30 19:48:52 +0000 |
|---|---|---|
| committer | Tanya Lattner <tonic@nondot.org> | 2013-01-30 19:48:52 +0000 |
| commit | 7564bcca9f2a56bdbde3c6788d3f09cca0d8e312 (patch) | |
| tree | b28df49b7ce12df0c3065500850635e620833907 | |
| parent | 1b6b31db169b66fb2048012b0ec1550c22cc64f4 (diff) | |
Add OpenCL error that a kernel function must have void return type. Includes a test case.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@173963 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | include/clang/Basic/DiagnosticSemaKinds.td | 2 | ||||
| -rw-r--r-- | lib/Sema/SemaDecl.cpp | 9 | ||||
| -rw-r--r-- | test/SemaOpenCL/invalid-kernel.cl | 4 |
3 files changed, 14 insertions, 1 deletions
diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td index a3b03033d2..e398da955b 100644 --- a/include/clang/Basic/DiagnosticSemaKinds.td +++ b/include/clang/Basic/DiagnosticSemaKinds.td @@ -6124,6 +6124,8 @@ def err_event_t_struct_field : Error< "the event_t type cannot be used to declare a structure or union field">; def err_event_t_addr_space_qual : Error< "the event_t type can only be used with __private address space qualifier">; +def err_expected_kernel_void_return_type : Error< + "kernel must have void return type">; } // end of sema category diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp index c94bf5f092..24dffc0299 100644 --- a/lib/Sema/SemaDecl.cpp +++ b/lib/Sema/SemaDecl.cpp @@ -6227,7 +6227,14 @@ Sema::ActOnFunctionDeclarator(Scope *S, Declarator &D, DeclContext *DC, Diag(D.getIdentifierLoc(), diag::err_static_kernel); D.setInvalidType(); } - + + // OpenCL v1.2, s6.9 -- Kernels can only have return type void. + if (!NewFD->getResultType()->isVoidType()) { + Diag(D.getIdentifierLoc(), + diag::err_expected_kernel_void_return_type); + D.setInvalidType(); + } + for (FunctionDecl::param_iterator PI = NewFD->param_begin(), PE = NewFD->param_end(); PI != PE; ++PI) { ParmVarDecl *Param = *PI; diff --git a/test/SemaOpenCL/invalid-kernel.cl b/test/SemaOpenCL/invalid-kernel.cl index a06b0e1e09..fb8ce5876f 100644 --- a/test/SemaOpenCL/invalid-kernel.cl +++ b/test/SemaOpenCL/invalid-kernel.cl @@ -1,3 +1,7 @@ // RUN: %clang_cc1 -verify %s kernel void no_ptrptr(global int **i) { } // expected-error{{kernel argument cannot be declared as a pointer to a pointer}} + +kernel int bar() { // expected-error {{kernel must have void return type}} + return 6; +} |