diff options
| author | Anders Carlsson <andersca@mac.com> | 2010-12-04 23:53:18 +0000 |
|---|---|---|
| committer | Anders Carlsson <andersca@mac.com> | 2010-12-04 23:53:18 +0000 |
| commit | 57d2d236d24de0edb7e51b86d88c0eb970330650 (patch) | |
| tree | 8ed8d37d26df7cea429fee7dee821a9e838b836d | |
| parent | 3cd1ea32c312dee47432dbb982f83bccff7356ac (diff) | |
Replace calls to AppendBytes with calls to AppendPadding when the bytes appended are padding.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@120922 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | clang.xcodeproj/project.pbxproj | 1 | ||||
| -rw-r--r-- | lib/CodeGen/CGRecordLayoutBuilder.cpp | 17 |
2 files changed, 7 insertions, 11 deletions
diff --git a/clang.xcodeproj/project.pbxproj b/clang.xcodeproj/project.pbxproj index 36660f04aa..877d81e61e 100644 --- a/clang.xcodeproj/project.pbxproj +++ b/clang.xcodeproj/project.pbxproj @@ -2063,6 +2063,7 @@ isa = PBXProject; buildConfigurationList = 1DEB923508733DC60010E9CD /* Build configuration list for PBXProject "clang" */; compatibilityVersion = "Xcode 2.4"; + developmentRegion = English; hasScannedForEncodings = 1; knownRegions = ( English, diff --git a/lib/CodeGen/CGRecordLayoutBuilder.cpp b/lib/CodeGen/CGRecordLayoutBuilder.cpp index 9b154d03bf..855552f960 100644 --- a/lib/CodeGen/CGRecordLayoutBuilder.cpp +++ b/lib/CodeGen/CGRecordLayoutBuilder.cpp @@ -136,7 +136,8 @@ private: /// AppendPadding - Appends enough padding bytes so that the total /// struct size is a multiple of the field alignment. - void AppendPadding(uint64_t FieldOffsetInBytes, unsigned FieldAlignment); + void AppendPadding(uint64_t FieldOffsetInBytes, + unsigned FieldAlignmentInBytes); /// getByteArrayType - Returns a byte array type with the given number of /// elements. @@ -325,7 +326,7 @@ void CGRecordLayoutBuilder::LayoutBitField(const FieldDecl *D, assert(FieldOffset % 8 == 0 && "Field offset not aligned correctly"); // Append padding if necessary. - AppendBytes((FieldOffset - NextFieldOffset) / 8); + AppendPadding(FieldOffset / 8, 1); NumBytesToAppend = llvm::RoundUpToAlignment(FieldSize, 8) / 8; @@ -393,13 +394,7 @@ bool CGRecordLayoutBuilder::LayoutField(const FieldDecl *D, return false; } - if (AlignedNextFieldOffsetInBytes < FieldOffsetInBytes) { - // Even with alignment, the field offset is not at the right place, - // insert padding. - uint64_t PaddingInBytes = FieldOffsetInBytes - NextFieldOffsetInBytes; - - AppendBytes(PaddingInBytes); - } + AppendPadding(FieldOffsetInBytes, TypeAlignment); // Now append the field. LLVMFields.push_back(LLVMFieldInfo(D, FieldTypes.size())); @@ -713,13 +708,13 @@ void CGRecordLayoutBuilder::AppendField(uint64_t FieldOffsetInBytes, } void CGRecordLayoutBuilder::AppendPadding(uint64_t FieldOffsetInBytes, - unsigned FieldAlignment) { + unsigned FieldAlignmentInBytes) { assert(NextFieldOffsetInBytes <= FieldOffsetInBytes && "Incorrect field layout!"); // Round up the field offset to the alignment of the field type. uint64_t AlignedNextFieldOffsetInBytes = - llvm::RoundUpToAlignment(NextFieldOffsetInBytes, FieldAlignment); + llvm::RoundUpToAlignment(NextFieldOffsetInBytes, FieldAlignmentInBytes); if (AlignedNextFieldOffsetInBytes < FieldOffsetInBytes) { // Even with alignment, the field offset is not at the right place, |