aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Dunbar <daniel@zuster.org>2010-09-17 23:21:43 +0000
committerDaniel Dunbar <daniel@zuster.org>2010-09-17 23:21:43 +0000
commit41e11a9315f7041c93e409f5d372013204e7cd04 (patch)
tree4c71fe2b46c416977bb3b810be554a922bbe66e0
parentc57d655921ad0b20e1af50cbab5595520bd5da85 (diff)
Sema/transparent_union: Make sure to add implicit cast when constructing
implicit union values for the transparent_union extension. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@114236 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/Sema/SemaExpr.cpp1
-rw-r--r--test/CodeGen/transparent-union.c22
2 files changed, 23 insertions, 0 deletions
diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp
index 83319a8087..c65db7e835 100644
--- a/lib/Sema/SemaExpr.cpp
+++ b/lib/Sema/SemaExpr.cpp
@@ -4954,6 +4954,7 @@ Sema::CheckTransparentUnionArgumentConstraints(QualType ArgType, Expr *&rExpr) {
if (CheckAssignmentConstraints(it->getType(), rExpr->getType())
== Compatible) {
+ ImpCastExprToType(rExpr, it->getType(), CK_Unknown);
InitField = *it;
break;
}
diff --git a/test/CodeGen/transparent-union.c b/test/CodeGen/transparent-union.c
new file mode 100644
index 0000000000..9f1cdda18d
--- /dev/null
+++ b/test/CodeGen/transparent-union.c
@@ -0,0 +1,22 @@
+// RUN: %clang_cc1 -triple i386-unknown-unknown -emit-llvm -o %t %s
+// RUN: FileCheck < %t %s
+//
+// FIXME: Note that we don't currently get the ABI right here. f0() should be
+// f0(i8*).
+
+typedef union {
+ void *f0;
+} transp_t0 __attribute__((transparent_union));
+
+void f0(transp_t0 obj);
+
+// CHECK: define void @f1_0(i32* %a0)
+// CHECK: call void @f0(%union.anon* byval %{{.*}})
+// CHECK: }
+void f1_0(int *a0) {
+ f0(a0);
+}
+
+void f1_1(int *a0) {
+ f0((transp_t0) { a0 });
+}