aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArgyrios Kyrtzidis <akyrtzi@gmail.com>2011-11-29 08:14:54 +0000
committerArgyrios Kyrtzidis <akyrtzi@gmail.com>2011-11-29 08:14:54 +0000
commit2fea2242fe7e7c37df1e96316616febeaf4e29eb (patch)
treec5c17f95a0c8e0da1fdcf53953a452ccdac30c89
parent7383550585795db4bd5ff635b650f01d374e91aa (diff)
Fix leaking of LexedMethod objects created for caching objc method definitions tokens
for late parsing. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@145394 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--include/clang/Parse/Parser.h3
-rw-r--r--lib/Parse/ParseObjc.cpp10
-rw-r--r--lib/Parse/Parser.cpp2
3 files changed, 14 insertions, 1 deletions
diff --git a/include/clang/Parse/Parser.h b/include/clang/Parse/Parser.h
index a1b346ee30..2c8f7ef986 100644
--- a/include/clang/Parse/Parser.h
+++ b/include/clang/Parse/Parser.h
@@ -402,6 +402,9 @@ private:
Tok.setKind(tok::eof);
}
+ /// \brief Clear and free the cached objc methods.
+ void clearLateParsedObjCMethods();
+
/// \brief Handle the annotation token produced for #pragma unused(...)
void HandlePragmaUnused();
diff --git a/lib/Parse/ParseObjc.cpp b/lib/Parse/ParseObjc.cpp
index 3cb2aaaec3..10c74ffdfd 100644
--- a/lib/Parse/ParseObjc.cpp
+++ b/lib/Parse/ParseObjc.cpp
@@ -1500,7 +1500,7 @@ Parser::ParseObjCAtEndDeclaration(SourceRange atEnd) {
// missing @implementation
Diag(atEnd.getBegin(), diag::err_expected_implementation);
- LateParsedObjCMethods.clear();
+ clearLateParsedObjCMethods();
ObjCImpDecl = 0;
return Actions.BuildDeclaratorGroup(
DeclsInGroup.data(), DeclsInGroup.size(), false);
@@ -1515,6 +1515,14 @@ Parser::DeclGroupPtrTy Parser::FinishPendingObjCActions() {
return Actions.ConvertDeclToDeclGroup(ImpDecl);
}
+void Parser::clearLateParsedObjCMethods() {
+ for (LateParsedObjCMethodContainer::iterator
+ I = LateParsedObjCMethods.begin(),
+ E = LateParsedObjCMethods.end(); I != E; ++I)
+ delete *I;
+ LateParsedObjCMethods.clear();
+}
+
/// compatibility-alias-decl:
/// @compatibility_alias alias-name class-name ';'
///
diff --git a/lib/Parse/Parser.cpp b/lib/Parse/Parser.cpp
index b4d41ef482..834e741e30 100644
--- a/lib/Parse/Parser.cpp
+++ b/lib/Parse/Parser.cpp
@@ -370,6 +370,8 @@ Parser::~Parser() {
it != LateParsedTemplateMap.end(); ++it)
delete it->second;
+ clearLateParsedObjCMethods();
+
// Remove the pragma handlers we installed.
PP.RemovePragmaHandler(AlignHandler.get());
AlignHandler.reset();