diff options
| author | Daniel Dunbar <daniel@zuster.org> | 2009-03-18 19:51:01 +0000 |
|---|---|---|
| committer | Daniel Dunbar <daniel@zuster.org> | 2009-03-18 19:51:01 +0000 |
| commit | 0ac86f0821a2ba7ae09793fee4451bef99e9b2f3 (patch) | |
| tree | 93ed75ed88b0bd2498554aa0a361dd06d92e8ca0 | |
| parent | 214399ebd73545dde02b4a45872e7ca9e1d9e742 (diff) | |
PR3835: Interaction with ABI structure passing can inhibit
readnone/readonly attributes.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@67224 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/CodeGen/CGCall.cpp | 6 | ||||
| -rw-r--r-- | test/CodeGen/struct-passing.c | 21 |
2 files changed, 27 insertions, 0 deletions
diff --git a/lib/CodeGen/CGCall.cpp b/lib/CodeGen/CGCall.cpp index 9e52cbb79c..fd33b50e79 100644 --- a/lib/CodeGen/CGCall.cpp +++ b/lib/CodeGen/CGCall.cpp @@ -1467,6 +1467,9 @@ void CodeGenModule::ConstructAttributeList(const CGFunctionInfo &FI, llvm::Attribute::StructRet | llvm::Attribute::NoAlias)); ++Index; + // sret disables readnone and readonly + FuncAttrs &= ~(llvm::Attribute::ReadOnly | + llvm::Attribute::ReadNone); break; case ABIArgInfo::Ignore: @@ -1493,6 +1496,9 @@ void CodeGenModule::ConstructAttributeList(const CGFunctionInfo &FI, Attributes |= llvm::Attribute::ByVal; Attributes |= llvm::Attribute::constructAlignmentFromInt(AI.getIndirectAlign()); + // byval disables readnone and readonly. + FuncAttrs &= ~(llvm::Attribute::ReadOnly | + llvm::Attribute::ReadNone); break; case ABIArgInfo::Direct: diff --git a/test/CodeGen/struct-passing.c b/test/CodeGen/struct-passing.c new file mode 100644 index 0000000000..305101d906 --- /dev/null +++ b/test/CodeGen/struct-passing.c @@ -0,0 +1,21 @@ +// RUN: clang -triple i386-pc-linux-gnu -emit-llvm -o %t %s && +// RUN: grep 'declare i32 @f0() readnone$' %t && +// RUN: grep 'declare i32 @f1() readonly$' %t && +// RUN: grep 'declare void @f2(.* noalias sret)$' %t && +// RUN: grep 'declare void @f3(.* noalias sret)$' %t && +// RUN: grep 'declare void @f4(.* byval)$' %t && +// RUN: grep 'declare void @f5(.* byval)$' %t && +// RUN: true +// PR3835 + +typedef int T0; +typedef struct { int a[16]; } T1; + +T0 __attribute__((const)) f0(void); +T0 __attribute__((pure)) f1(void); +T1 __attribute__((const)) f2(void); +T1 __attribute__((pure)) f3(void); +void __attribute__((const)) f4(T1 a); +void __attribute__((pure)) f5(T1 a); + +void *ps[] = { f0, f1, f2, f3, f4, f5 }; |