CLJ-665 test improvements: don't touch a core var, and verify that value is put back correctly

Signed-off-by: Stuart Halloway <stu@thinkrelevance.com>

1 files changed, 11 insertions, 9 deletions

diff --git a/test/clojure/test_clojure/vars.clj b/test/clojure/test_clojure/vars.clj
index 26e43ad9..82126576 100644
--- a/test/clojure/test_clojure/vars.clj
+++ b/test/clojure/test_clojure/vars.clj
@@ -62,28 +62,30 @@
 
 ; doc find-doc test
 
+(def stub-me :original)
+
 (deftest test-with-redefs-fn
   (let [p (promise)]
-    (with-redefs-fn {#'nil? :temp}
+    (with-redefs-fn {#'stub-me :temp}
       (fn []
-        (.start (Thread. #(deliver p nil?)))
+        (.start (Thread. #(deliver p stub-me)))
         @p))
     (is (= :temp @p))
-    (is (not= @p nil?))))
+    (is (= :original stub-me))))
 
 (deftest test-with-redefs
   (let [p (promise)]
-    (with-redefs [nil? :temp]
-      (.start (Thread. #(deliver p nil?)))
+    (with-redefs [stub-me :temp]
+      (.start (Thread. #(deliver p stub-me)))
       @p)
     (is (= :temp @p))
-    (is (not= @p nil?))))
+    (is (= :original stub-me))))
 
 (deftest test-with-redefs-throw
   (let [p (promise)]
     (is (thrown? Exception
-      (with-redefs [nil? :temp]
-        (deliver p nil?)
+      (with-redefs [stub-me :temp]
+        (deliver p stub-me)
         (throw (Exception. "simulated failure in with-redefs")))))
     (is (= :temp @p))
-    (is (not= @p nil?))))
+    (is (= :original stub-me))))