aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2010-05-16NOR: add read() callback to struct flash_driverAntonio Borneo
Final target is to force bus_width size during CFI flash read. In this first step I need to replace default flash read with flash specific implementation. This patch introduces: - flash_driver_read() layer; - default_flash_read(), backward compatible; - read() callback in struct flash_driver; - proper initialization in every flash_driver instance. Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
2010-05-16NOR/TCL: fix typo in error messageAntonio Borneo
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
2010-05-16NOR: fix comment for DoxygenAntonio Borneo
Either bus_width and chip_width are in bytes. Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
2010-05-16NOR/CFI: remove use of cfi_add_byte()Antonio Borneo
Remove the function cfi_add_byte() and rewrite the only instance of it. Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
2010-05-16NOR/CFI: use bus_width for memory access in cfi_write()Antonio Borneo
During cfi_write(), head and tail of destination area could be not aligned to bus_width. Since write operation must be at bus_width size, source buffer size is extended and buffer padded with current values read from flash. Force using bus_width to read current value from flash. Do not use cfi_add_byte() anymore, to allow removing this function later on. Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
2010-05-16NOR/CFI: use bus_width for memory access on flash ID.Antonio Borneo
NOR flash structure requires each access to be bus_width wide. Fix read of flash ID accordingly to rule above. Add case (chip_width == 4), allowed by CFI spec and coherent with current value of CFI_MAX_CHIP_WIDTH but currently not used by any target. Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
2010-05-16NOR/CFI: identify memory accesses not using "bus_width".Antonio Borneo
Since NOR flash devices does not handle "byte enable lanes", each read/write access involves the whole "chip_width". When multiple devices are in parallel, usually all chips are enabled during each access. All such cases are compatible with flash accesses at "bus_width" size. Access at "bus_width" size is mandatory for write access to avoid transferring of garbage values to flash. During read access the flash controller should take care, and discard unneeded bytes. Anyway, it is good practice to use "bus_width" size also for read. Every memory access that does not respect "bus_width" size is marked with a "FIXME" comment. Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
2010-05-16NOR/CFI: simplify bufferwsize computationAntonio Borneo
Review and simplify computation of bufferwsize. Add comments about variables' meaning. The same code is present 3 times in the file. Current patch updates all the 3 instances. Step 1) Replace "switch(bank->chip_width) {...}". Illegal values of bank->chip_width are already dropped. For legal values, the code is equivalent to: bufferwsize = buffersize / bank->chip_width; Step 2) The above code replacement plus the following line: bufferwsize /= (bank->bus_width / bank->chip_width); is merged in a single formula: bufferwsize = (buffersize / bank->chip_width) / (bank->bus_width / bank->chip_width); and simplified as: bufferwsize = buffersize / bank->bus_width; Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
2010-05-16NOR/CFI: check "flash bank" command argumentsAntonio Borneo
Arguments chip_width and bus_width of command "flash bank" are not fully checked. While bus_width is later on redundantly checked in several other parts (e.g. in cfi_command_val()) and generates run-time error, chip_width is never checked, nor related to actual bus_width value. Added check to avoid: - (chip_width == 0), that would mean no memory chip at all, avoiding also division by zero e.g. in cfi_get_u8(); - (bus_width == 0), that would mean no bus at all; - unsupported cases of chip_width or bus_width value not power of 2; - unsupported case of chip width wider than bus. Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
2010-05-15comments on doc/manual/primer/jtag.txtJun Ma
1. fix some errors in jtag.txt(in my personal opinion, please review). 2. remove a broken link Signed-off-by: Jun Ma <sync.jma@gmail.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-14missing pointer's declaration when enable macro -D_DEBUG_GDB_IO_.Jun Ma
reproducable when "./configure --enable-maintainer-mode CFLAGS=-D_DEBUG_GDB_IO_" Signed-off-by: Jun Ma <sync.jma@gmail.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-14NAND: fix first and last handling in nand_build_bbtJon Povey
Last block was being skipped, fix by changing the loop test from "<" to "<=" First block argument was ignored, always started from block 0 (and counted the wrong blocks as bad if first was nonzero). Now we use it. Signed-off-by: Jon Povey <jon.povey@racelogic.co.uk> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-14NAND: fix off-by-one error in erase command argument rangeJon Povey
The last_block argument to nand_erase() is checked against nand->num_blocks, but the highest valid block number is (total - 1), the test for invalid should be ">=" rather than ">". Signed-off-by: Jon Povey <jon.povey@racelogic.co.uk> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-13scripts: update flash bank namesSpencer Oliver
As the flash bank name is now unique update the scripts to suit. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-05-13flash: require unique flash bank nameSpencer Oliver
Make sure the flash bank name is unique Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-05-13flash: add flash bank name supportSpencer Oliver
flash cmds can now be passed either the bank name or the bank number. For example. flash info stm32.flash flash info 0 Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-05-12zy1000.cfg: gdb connect will fail first time without gdb-attachØyvind Harboe
gdb-attach does a reset init to make sure that the CFI probe will succeed upon first gdb connect. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-12fix instruction refilling bug when using software breakpoints on a ↵Jun Ma
big-endian arm926ej-s system Signed-off-by: Jun Ma <sync.jma@gmail.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-11Fujitsu MBM29SL800TE flash supportKarl Kurbjun
Hi, This is my first post to the list. First, I would like to thank everyone for their work on OpenOCD, it is a great tool to work with. I have been using it to debug code on hardware for the Rockbox project (www.rockbox.org). The target that I primarily work with has a Spansion/Fujitsu NOR flash (MBM29SL800TE). I attached a patch that adds support for this flash. I hope it can be included in the main repository. If there is something that needs to be changed with the patch before inclusion please let me know. -Karl Kurbjun
2010-05-11Documentation: consistency in GDB command nameMarc Pignat
Always use the complete name of the GDB command, not an abbreviation.
2010-05-11Documentation : arm920t implements armv4Marc Pignat
There is a small typo in the cpu list, arm920t is armv4.
2010-05-10mips32: 20 second timeout/megabyte for CRC checkSpencer Oliver
There was a fixed 20 second timeout which is too little for large, slow timeout checks. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-05-10armv7m: 20 second timeout/megabyte for CRC checkSpencer Oliver
There was a fixed 20 second timeout which is too little for large, slow timeout checks. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-05-10cfi: add Numonyx M29W128G reset workaroundSpencer Oliver
The ST/Numonix M29W128G has an issue when a 0xff cmd is sent, it cause an internal undefined state. The workaround according to the Numonyx is to send another 0xf0 reset cmd Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-05-07cfg: add stm32eval board configsSpencer Oliver
Increase working area for stm3210e_eval.cfg. Add new configs for the following boards: STM321000B-EVAL, STM32100C-EVAL, STM32100B-EVAL Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-05-06server: incorrectly display socket port numberSpencer Oliver
c->sin.sin_port does not contain a valid port number so just use service->port as this is always correct. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-05-05flash: stop caching protection stateØyvind Harboe
There are a million reasons why cached protection state might be stale: power cycling of target, reset, code executing on the target, etc. The "flash protect_check" command is now gone. This is *always* executed when running a "flash info". As a bonus for more a more robust approach, lots of code could be deleted. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-05flash: erase_address now has an unlock optionØyvind Harboe
Quite useful to be able to unlock the flash, just like in the flash write_image cmd. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-05cfi: fix error handling for protect fnØyvind Harboe
No error was propagated. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-05zy1000: fix tcl command to read power dropout statusØyvind Harboe
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-05gdb: connect will now fail if flash autoprobe failsØyvind Harboe
This stops GDB from launching with an empty memory map, making gdb load w/flashing fail for no obvious reason. The error message points in the direction of the gdb-attach event that can be set up to issue a halt or "reset init" which will put GDB in a well defined stated upon attach and thus have a robust flash autoprobe. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-05zy1000: fix keep_alive() bugØyvind Harboe
introduced in latest commit. Should have held off merging that commit. Sigh.... Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-05Fixed bug in tcl-serverMatthias Bode
No segmentationfault when sending commands to tcl-server. modified: src/server/server.c modified: src/server/tcl_server.c modified: src/server/tcl_server.h
2010-05-05command context: fix errors when running certain commands on startupØyvind Harboe
Various commands, e.g. "arm mcr xxxx" would fail if invoked upon startup since it there was no command context defined for the jim interpreter in that case. A Jim interpreter is now associated with a command context(telnet, gdb server's) or the default global command context. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-05flash: more flash write_image bugfixesØyvind Harboe
Remove/fix lots of bugs in handling of non-contigious sections and out of order sections. Fix a gaffe introduced in previous commit to src/flash/nor/core.c Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-05str7x: improve error handlingØyvind Harboe
clean up error handling a bit. No change in behavior. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-05documentation typoMarc Pignat
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-05docs: now builds againØyvind Harboe
Fix gaffe committed last time. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-04str71x: fix previous commitSpencer Oliver
fix build issue with 70226c221f5879bb6126ff3f2ec9ae64c68d80d6 commit Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-05-04flash: less bogus errorsØyvind Harboe
Removed bogus errors when trying to allocate a large a target memory buffer as possible. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-04str7x: fix bogus error messagesØyvind Harboe
Remove bogus error messages when trying to allocate a large chunk of target memory and then falling back to a smaller one. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-04target: clean up target memory allocation error messagesØyvind Harboe
target memory allocation can be implemented not to show bogus error messages. E.g. when trying a big allocation first and then a smaller one if that fails. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-04zy1000: wait for srst to deassertØyvind Harboe
make wait for srst deassert more long latency friendly (JTAG over TCP/IP), print actual time if it was more than 1ms. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-04cfi: made som info output debug outputØyvind Harboe
E.g. how much target memory that is used during flashing is debug info. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-05-03STM32 flash erase timeout fixTobias Ringström
The current timeout for STM32 flash block erase and flash mass erase is 10 (ms), which is too tight, and fails around 50% of the time for me. The data sheet for STM32F107VC specifies a maximum erase time of 40 ms (for both operations). I'd also consider it a bug that the code does not detect a timeout, but just assumes that the operation has completed. The attached patch does not address this bug. The attached patch increases the timeouts from 10 to 100 ms. Please apply. /Tobias
2010-04-30zy1000: it has a CFI chip, no need for the ecosflash driverØyvind Harboe
The ecosflash driver is no longer used by any of the config scripts. It is more useful to get more testing of CFI. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-04-29flash: write_image would fail for certain imagesØyvind Harboe
Fix a bug where write_image would fail if the sections in the image were not in ascending order. This has previously been fixed in gdb load. Solved by sorting the image sections before running flash write_image erase unlock foo.elf. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-04-29flash: write_image will now pad erase to nearest sectorØyvind Harboe
this is done for unlocking and it is a simple omission that it wasn't done for sectors. The unnerving thing is that nobody has complained about this until now.... Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-04-28nor: remove bogus output about padding sectionsØyvind Harboe
padding of 0 bytes is actually no padding, do not output warning about padding in that case. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-04-26Add Voipac PXA270 module supportMarek Vasut
This patch adds support for the Voipac PXA270 module. Including NOR flash. Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
generated by cgit v1.2.3-18-g5258 (git 2.32.0) at 2024-10-18 10:30:39 +0000