aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2010-12-29Compilation Warnings on OS X 10.5Andrew MacIsaac
I received a number of "-Wshadow" related warnings (treated as errors) while trying to build on OS X Leopard. In addition, there were two miscellaneous other warnings in the flash drivers. Attached are two patches which correct these issues and the commit messages to accompany them. My system has the following configuration (taken from uname -a): Darwin 9.8.0 Darwin Kernel Version 9.8.0: Wed Jul 15 16:55:01 PDT 2009; root:xnu-1228.15.4~1/RELEASE_I386 i386 === Werror_patch.txt Commit Message === compilation: fixes for -Wshadow warnings on OS X These changes fix -Wshadow compilation warnings on OS X 10.5.8 Compiled with the following configure command: ../configure --prefix=/usr/local --enable-maintainer-mode --enable-jlink --enable-ft2232_libftdi === flash_patch.txt Commit Message === compilation: fixes for flash driver warnings on OS X These changes fix two compilation warnings on OS X 10.5.8: ../../../../src/flash/nor/at91sam3.c:2767: warning: redundant redeclaration of 'at91sam3_flash' ../../../../src/flash/nor/at91sam3.c:101: warning: previous declaration of 'at91sam3_flash' was here and ../../../../src/flash/nor/stmsmi.c:205: warning: format not a string literal and no format arguments Compiled with the following configure command: ../configure --prefix=/usr/local --enable-maintainer-mode --enable-jlink --enable-ft2232_libftdi === Andrew
2010-12-29warning: fix warning where GCC didn't catch a doubly declared global structureØyvind Harboe
Why hasn't earlier versions of GCC caught this? Bug? Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-12-29warnings: use more 'const' for char *Øyvind Harboe
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-12-29target: do not expose error numbers to usersØyvind Harboe
error numbers are only reported at DEBUG log levels and used internally, they are not part of the user interface. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-12-24initial SWD transport (SWD infrastructure #2)David Brownell
This piggy backs on JTAG so it's not yet pretty, but that seems unavoidable so far given today's OpenOCD internals. SWD init and data transfer are unfinished and untested, but that should cause no regressions, and will be addressed by the time drivers start using this infrastructure. Checking in whould get the code working better sooner, and turn up any structural/architectural issues while they're easier to fix. The debug adapter drivers will provide simple SWD driver structs with methods that kick in as needed (instead of JTAG). So far just one adapter driver has been updated (not yet ready to use or circulate). The biggest issues are probably - fault handling, where the ARM Debug Interface V5 pipelining needs work in both JTAG and SWD modes and - missing rewrite of block I/O code to work on both of our Cortex-ready transports (Current code is hard-wired to JTAG); relates also to the pipelining issue. - omitted support to activate/deactivate SWO/SWV trace (this is technically trivial, but configuring what to trace is NOT. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> ---- doc/openocd.texi | 17 ++ src/jtag/core.c | 3 src/jtag/interface.h | 4 src/jtag/jtag.h | 2 src/jtag/swd.h | 114 +++++++++++++++++++ src/jtag/tcl.c | 2 src/target/adi_v5_swd.c | 281 ++++++++++++++++++++++++++++++++++++++++++++++-- src/target/arm_adi_v5.c | 8 + src/target/arm_adi_v5.h | 3 9 files changed, 425 insertions(+), 9 deletions(-)
2010-12-23stm32x : always use valid flash base addressSpencer Oliver
This change matches the previous behaviour of using the known flash address. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-23flash: print flash bank name on flash info cmdSpencer Oliver
The flash bank name is a required element in adding flash banks, however other than looking at the config file there is no way of getting the name used in openocd. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-23stm32: fix reversed option byte writeSpencer Oliver
This has been a long standing bug that has never been spotted. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-23stm32: update option bytes for stm32xl familySpencer Oliver
add supoort for xl family boot bank option. The option byte handling will be cleaned up in a later patch. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-23stm32: add stm32 xl family flash supportSpencer Oliver
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-23stm32: add dual flash bank supportSpencer Oliver
This patch adds the initial dual flash bank support for devices such as the stm32xl family. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-23contrib: change stm32 flash loader extensionSpencer Oliver
As the stm32 flash loader now uses the preprocessor change extension so that it used by default. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-22lpc2148: redo to the new target configuration schemeØyvind Harboe
Define a proc which PCBs can easily override. Also demonstrates how to add multiple TAP exepcted-id's using arguments. Added 0x3f0f0f0f as expected TAP-id. Old LPC2148 silicon I happened to have on my desk? Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-12-22config: add init_targets proc that is executed just before initØyvind Harboe
this allows configuration scripts to export a init_targets proc rather than setting up the target directly. This allows for new conventions in how to set up target vs. board script and how to transfer default settings between board and target scripts. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-12-22bootstrap: by default the submodules are initializedØyvind Harboe
use "nosubmodule" to skip setting up submodules. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-12-21server: remove error value from LOG_INFOØyvind Harboe
the error values is not part of the interface to the user, so they should never be printed in LOG_INFO or LOG_USER. Printing them in LOG_DEBUG() rarely makes much sense but is OK. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-12-20tcl/interface/flashlink.cfg: Fix broken ST URLTormod Volden
2010-12-20tcl/board: Clean up STM32 EVAL boards configurationsTormod Volden
Make consistent use of hex memory size for flashing. Delete stm32f10x_128k_eval.cfg. It has no product reference nor any settings in it.
2010-12-20tcl/board: Fix ST URLs in stm32* eval board configuration filesTormod Volden
ST recently rewamped (screwed up) their web site and broke all links. Also match the chip names with those on the web site product descriptions.
2010-12-19update IXP42x target / XBA board configMichael Schwingen
2010-12-18Add support for Hilscher netX controllersMichael Trensch
2010-12-18script: support only Tcl commentsØyvind Harboe
Only Tcl comments are now supported. For classic style commands comments were supported at the end of the line. Move in the direction of letting the script language decide syntax, rather than have special rules for some commands. Before this patch goes in, the scripts should be updated to use ;# instead of # for end of line comments. > mdw 0 1 2 mdw ['phys'] address [count] zy1000.cpu mdw address [count] Command handler execution failed in procedure 'mdw' > mdw 0 1 #2 mdw ['phys'] address [count] zy1000.cpu mdw address [count] Command handler execution failed in procedure 'mdw' > mdw 0 1 ;#2 0x00000000: ffffffff > mdw 0 1 0x00000000: ffffffff > mdw 0 0x00000000: ffffffff Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-12-18TCL: fix non TCL commentsAntonio Borneo
End of line comments fixed with ';' before '#'. Added few additional 'space' to keep indentation in multi-line comments. Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
2010-12-16openocd doc: update the comments about Jim Tcl a bitØyvind Harboe
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-12-16Fix for compilation failure amt_jtagaccel.cJohn Devereux
Hi, I think there are errors in amt_jtagaccel.c I attach a small patch that I needed to make it compile.
2010-12-15Fix for segfault in handle_nand_dump_command.Paul Richards
2010-12-15stm32: fix unprotectØyvind Harboe
the unprotect fn in stm32 needs to unprotect more sectors than was requested aligned to some boundary. Print warning when this happens. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-12-15flash: clarify protect documentationØyvind Harboe
some chips unprotect more than the range asked for. The protect fn, must unprotect/protect minimally the range given. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-12-10contrib: add source to the cfi flash loadersSpencer Oliver
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-10contrib: make sure loaders use correct archSpencer Oliver
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-10stm32: add STM32E-EVAL external memory config scriptSpencer Oliver
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-10cfi: disable buffer writes for M29W128GSpencer Oliver
For some reason buffer writes for the M29W128G do not work reliably, so disable them. See: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=504a3e72208fc6a65924426ff5693982590bccdc Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-10cfi: allow optional buffer write supportSpencer Oliver
Some flash's do not support buffer writes, so we now check they are supported before trying to use them. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-10cfi: calculate correct timeoutsSpencer Oliver
The existing code used incorrect timeout values for the various cfi operations. We now calculate the timeouts and convert to msecs if necessary. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-10cfi: prefix string hex outputSpencer Oliver
Add hex prefix so we know output is not decimal. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-10cfi: add time format to cfi query outputSpencer Oliver
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-10cfi: whitespace and long line cleanupSpencer Oliver
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-10Fix for segmentation fault from freed memory access in ↵Paul Richards
jtag_unregister_event_callback()
2010-12-09remove srst_pulls_trst from LPC2xxx target scriptsFreddie Chopin
LPC2xxx do not require reset_config srst_pulls_trst. This can cause various "strange" problems when flashing the chip, because "reset halt" actually allows the chip to run for some short period of time and execute some code. Signed-off-by: Freddie Chopin <freddie_chopin@op.pl>
2010-12-08build: fix build from previous commitSpencer Oliver
commit 740b9e25b410c164e661d0334a9ea4168406726b broke the drivers for ftdi and parport due to retval already being defined. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-08jtag: getting the JTAG speed can failØyvind Harboe
If the JTAG speed has not been set, then it has no defined value, add code to propagate the error. No change to actual behavior as no new failure paths have been introduced. This is a no-op patch to make subsequent patches smaller. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2010-12-07svf: various improvementsAndrew Leech
* added support for targeting particular tap * improved file reading * improved command line parsing * added progress meter * more readable time measurement output
2010-12-05lpc2478 target config: CCLK as (mandatory) parameterRolf Meeser
2010-12-04xscale: trace buffer remains enabled until explicitly disabledMike Dunn
Hi everyone, Since a call went out for patches... been sitting on this for months. For some reason, the xscale trace buffer is automatically disabled as soon as a break occurs and the trace data is collected. This patch was a result of the frustration of always re-enabling it, or else hitting a breakpoint and checking the trace data, only to discover that I forgot to re-enable it before resuming. Don't see why it should work this way. There is no run-time penalty, AFAIK. Along the way, I also cleaned up a little by removing the ugly practice of recording wrap mode by setting the fill count variable to "-1", replacing it with an enum that records the trace mode. I've been using this for months. Comments, criticisms gratefully received. Mike Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
2010-12-04Add board config for Embedded Artists LPC2478-32Rolf Meeser
2010-12-04Fix flash name in Hitex LPC2929 board configRolf Meeser
2010-12-04Fix sector layout for 504-KiB LPC2000 devicesRolf Meeser
2010-12-03stm32: set default soft reset configSpencer Oliver
If no srst is configured then default to using sysresetreq to reset the target. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-03luminary: remove unused config cmds.Spencer Oliver
Due to commit e40aee2954d2beabe1d8c530d9ff1e564fb01f48 we now honour the targets 'reset_config' setting. Previously we ignored the srst setting for luminary targets. Luminary targets have never supported using srst to reset into debug mode so remove the option from the target configs files. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
2010-12-03cortex_m3: change cortec_m3 reset_config behaviourSpencer Oliver
Currently the cmd 'cortex_m3 reset_config' will overide the default target's 'reset_config'. Chnage the behaviour to use the target 'reset_config' if configured and fallback if not. Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>