diff options
| author | Paul Fertser <fercerpav@gmail.com> | 2018-01-18 00:07:29 +0300 |
|---|---|---|
| committer | Tomas Vanek <vanekt@fbl.cz> | 2018-01-25 07:22:57 +0000 |
| commit | e3a5f1613bcceb4508917a7f79348167503effab (patch) | |
| tree | ec5014601a3e1cad3294babf8c08875b0f36e43a /src | |
| parent | f02327d85953152743dbb02d9ceeaa5b59da9ebe (diff) | |
flash: nor: stm32l4x: fix warning in probe
Reading options word can fail, so this needs to be handled.
Reported by Clang static analyzer.
Change-Id: I9754cab9c4446fa2b20d4b44b0e20724d1bc1beb
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/4352
Tested-by: jenkins
Reviewed-by: Tim "mithro" Ansell <mithro@mithis.com>
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Diffstat (limited to 'src')
| -rw-r--r-- | src/flash/nor/stm32l4x.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/flash/nor/stm32l4x.c b/src/flash/nor/stm32l4x.c index fa0c48b4..6a1fa074 100644 --- a/src/flash/nor/stm32l4x.c +++ b/src/flash/nor/stm32l4x.c @@ -652,6 +652,9 @@ static int stm32l4_probe(struct flash_bank *bank) /* get options to for DUAL BANK. */ retval = target_read_u32(target, STM32_FLASH_OPTR, &options); + if (retval != ERROR_OK) + return retval; + /* only devices with < 1024 kiB may be set to single bank dual banks */ if ((flash_size_in_kb == 1024) || !(options & OPT_DUALBANK)) stm32l4_info->option_bytes.bank_b_start = 256; |