diff options
author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2014-12-09 11:11:30 +0100 |
---|---|---|
committer | Paul Fertser <fercerpav@gmail.com> | 2015-01-28 06:57:57 +0000 |
commit | 24fb042a73c3e4c68d1f583062b3b096c92d5f7d (patch) | |
tree | c45c406bfe12177fda70c7477b91064e9463bdfc /src/target | |
parent | fe04314c2affada149f80858ee90e9b671ab9d25 (diff) |
ARMv7-A: remove useless switch construct
The default label does just return the same error code as the case for
zero, so this can be handled by a simple if statement.
Change-Id: I61a8cb51b5e261f21eca386af7d8cbf17ffa2d44
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-on: http://openocd.zylin.com/2430
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Diffstat (limited to 'src/target')
-rw-r--r-- | src/target/armv7a.c | 26 |
1 files changed, 11 insertions, 15 deletions
diff --git a/src/target/armv7a.c b/src/target/armv7a.c index 57b8799f..ca599eb6 100644 --- a/src/target/armv7a.c +++ b/src/target/armv7a.c @@ -564,21 +564,17 @@ COMMAND_HANDLER(handle_cache_l2x) { struct target *target = get_current_target(CMD_CTX); uint32_t base, way; - switch (CMD_ARGC) { - case 0: - return ERROR_COMMAND_SYNTAX_ERROR; - break; - case 2: - /* command_print(CMD_CTX, "%s %s", CMD_ARGV[0], CMD_ARGV[1]); */ - COMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], base); - COMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], way); - - /* AP address is in bits 31:24 of DP_SELECT */ - armv7a_l2x_cache_init(target, base, way); - break; - default: - return ERROR_COMMAND_SYNTAX_ERROR; - } + + if (CMD_ARGC != 2) + return ERROR_COMMAND_SYNTAX_ERROR; + + /* command_print(CMD_CTX, "%s %s", CMD_ARGV[0], CMD_ARGV[1]); */ + COMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], base); + COMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], way); + + /* AP address is in bits 31:24 of DP_SELECT */ + armv7a_l2x_cache_init(target, base, way); + return ERROR_OK; } |