diff options
| author | Andreas Fritiofson <andreas.fritiofson@gmail.com> | 2013-09-28 17:28:25 +0200 |
|---|---|---|
| committer | Spencer Oliver <spen@spen-soft.co.uk> | 2013-10-31 20:42:47 +0000 |
| commit | 13f6c889ab9b6e5b1c4f48fca9807fdc1fb83f42 (patch) | |
| tree | fd5412ade9345f19316dcbee5ea39f961f34509a /src/target | |
| parent | 517ba0690dcc9e859a05df2113ce32401a5ab254 (diff) | |
Remove unnecessary (void *)
When pointer casts are needed, cast directly to the correct type, instead
of going via void*.
Don't explicitly cast to void* if it would have been done implicitly.
Change-Id: I4093209200051c5eb62847d00a4b9c8567480068
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1669
Tested-by: jenkins
Reviewed-by: Mathias Küster <kesmtp@freenet.de>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Diffstat (limited to 'src/target')
| -rw-r--r-- | src/target/adi_v5_jtag.c | 2 | ||||
| -rw-r--r-- | src/target/arm11_dbgtap.c | 2 | ||||
| -rw-r--r-- | src/target/arm_semihosting.c | 2 | ||||
| -rw-r--r-- | src/target/armv7a.c | 4 | ||||
| -rw-r--r-- | src/target/etm.c | 4 | ||||
| -rw-r--r-- | src/target/mips_ejtag.c | 2 |
6 files changed, 8 insertions, 8 deletions
diff --git a/src/target/adi_v5_jtag.c b/src/target/adi_v5_jtag.c index 62eb7d12..7f61563f 100644 --- a/src/target/adi_v5_jtag.c +++ b/src/target/adi_v5_jtag.c @@ -356,7 +356,7 @@ static int jtag_idcode_q_read(struct adiv5_dap *dap, fields[0].num_bits = 32; fields[0].out_value = NULL; - fields[0].in_value = (void *) data; + fields[0].in_value = (uint8_t *) data; jtag_add_dr_scan(jtag_info->tap, 1, fields, TAP_IDLE); diff --git a/src/target/arm11_dbgtap.c b/src/target/arm11_dbgtap.c index d7cd020f..fd8d2540 100644 --- a/src/target/arm11_dbgtap.c +++ b/src/target/arm11_dbgtap.c @@ -599,7 +599,7 @@ int arm11_run_instr_data_to_core_noack_inner_default(struct jtag_tap *tap, uint8_t *ReadyPos = Readies; while (count--) { - chain5_fields[0].out_value = (void *)(data++); + chain5_fields[0].out_value = (uint8_t *)(data++); chain5_fields[1].in_value = ReadyPos++; if (count > 0) { diff --git a/src/target/arm_semihosting.c b/src/target/arm_semihosting.c index bdf572ec..06a433f2 100644 --- a/src/target/arm_semihosting.c +++ b/src/target/arm_semihosting.c @@ -323,7 +323,7 @@ static int do_semihosting(struct target *target) if (l < s) result = -1; else { - retval = target_write_buffer(target, a, s, (void *)arg); + retval = target_write_buffer(target, a, s, (uint8_t *)arg); if (retval != ERROR_OK) return retval; result = 0; diff --git a/src/target/armv7a.c b/src/target/armv7a.c index 6a41e0db..bfe4ef4d 100644 --- a/src/target/armv7a.c +++ b/src/target/armv7a.c @@ -468,7 +468,7 @@ static int armv7a_l2x_cache_init(struct target *target, uint32_t base, uint32_t l2x_cache->base,l2x_cache->way);*/ if (armv7a->armv7a_mmu.armv7a_cache.l2_cache) LOG_INFO("cache l2 already initialized\n"); - armv7a->armv7a_mmu.armv7a_cache.l2_cache = (void *) l2x_cache; + armv7a->armv7a_mmu.armv7a_cache.l2_cache = l2x_cache; /* initialize l1 / l2x cache function */ armv7a->armv7a_mmu.armv7a_cache.flush_all_data_cache = armv7a_l2x_flush_all_data; @@ -482,7 +482,7 @@ static int armv7a_l2x_cache_init(struct target *target, uint32_t base, uint32_t armv7a = target_to_armv7a(curr); if (armv7a->armv7a_mmu.armv7a_cache.l2_cache) LOG_ERROR("smp target : cache l2 already initialized\n"); - armv7a->armv7a_mmu.armv7a_cache.l2_cache = (void *) l2x_cache; + armv7a->armv7a_mmu.armv7a_cache.l2_cache = l2x_cache; armv7a->armv7a_mmu.armv7a_cache.flush_all_data_cache = armv7a_l2x_flush_all_data; armv7a->armv7a_mmu.armv7a_cache.display_cache_info = diff --git a/src/target/etm.c b/src/target/etm.c index be5dd020..ebffd48a 100644 --- a/src/target/etm.c +++ b/src/target/etm.c @@ -318,7 +318,7 @@ struct reg_cache *etm_build_reg_cache(struct target *target, etm_core, 1); etm_get_reg(reg_list); - etm_ctx->config = buf_get_u32((void *)&arch_info->value, 0, 32); + etm_ctx->config = buf_get_u32(&arch_info->value, 0, 32); config = etm_ctx->config; /* figure ETM version then add base registers */ @@ -334,7 +334,7 @@ struct reg_cache *etm_build_reg_cache(struct target *target, etm_core + 1, 1); etm_get_reg(reg_list + 1); etm_ctx->id = buf_get_u32( - (void *)&arch_info[1].value, 0, 32); + &arch_info[1].value, 0, 32); LOG_DEBUG("ETM ID: %08x", (unsigned) etm_ctx->id); bcd_vers = 0x10 + (((etm_ctx->id) >> 4) & 0xff); diff --git a/src/target/mips_ejtag.c b/src/target/mips_ejtag.c index 3457b78b..6d51c56f 100644 --- a/src/target/mips_ejtag.c +++ b/src/target/mips_ejtag.c @@ -422,7 +422,7 @@ int mips_ejtag_fastdata_scan(struct mips_ejtag *ejtag_info, int write_t, uint32_ fields[1].in_value = NULL; buf_set_u32(t, 0, 32, *data); } else - fields[1].in_value = (void *) data; + fields[1].in_value = (uint8_t *) data; jtag_add_dr_scan(tap, 2, fields, TAP_IDLE); |