diff options
| author | Øyvind Harboe <oyvind.harboe@zylin.com> | 2011-10-30 18:36:47 +0100 |
|---|---|---|
| committer | Spencer Oliver <spen@spen-soft.co.uk> | 2011-10-31 11:04:42 +0000 |
| commit | fc553327c0a40b3039388bf9139aad2f9dc8fdf1 (patch) | |
| tree | 925860f0af776063f59565e22bccf7abf5bd75b8 /src/target | |
| parent | c0e1bfa8b4c8096666494be8fd99f2862bdf67a2 (diff) | |
dsp563xxx: fix missing error propagation found by clang
Change-Id: I7380ce145b4942e21b174f2a810928a877c32bc7
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/140
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Diffstat (limited to 'src/target')
| -rw-r--r-- | src/target/dsp563xx.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/src/target/dsp563xx.c b/src/target/dsp563xx.c index b7f23c70..a0e12062 100644 --- a/src/target/dsp563xx.c +++ b/src/target/dsp563xx.c @@ -1323,7 +1323,7 @@ static int dsp563xx_run_algorithm(struct target *target, int timeout_ms, void *arch_info) { int i; - int retvaltemp,retval = 0; + int retval = ERROR_OK; struct dsp563xx_common *dsp563xx = target_to_dsp563xx(target); if (target->state != TARGET_HALTED) @@ -1376,10 +1376,12 @@ static int dsp563xx_run_algorithm(struct target *target, for (i = 0; i < num_mem_params; i++) { if (mem_params[i].direction != PARAM_OUT) - if ((retvaltemp = target_read_buffer(target, mem_params[i].address, mem_params[i].size, mem_params[i].value)) != ERROR_OK) - { - retval = retvaltemp; - } + retval = target_read_buffer(target, + mem_params[i].address, + mem_params[i].size, + mem_params[i].value); + if (retval != ERROR_OK) + return retval; } for (i = 0; i < num_reg_params; i++) |