diff options
author | David Brownell <dbrownell@users.sourceforge.net> | 2009-11-15 10:35:25 -0800 |
---|---|---|
committer | David Brownell <dbrownell@users.sourceforge.net> | 2009-11-15 10:35:25 -0800 |
commit | 9ac7cdec82c19481b79f2effcefb7106dd7ade41 (patch) | |
tree | 6252be3bf24ee465b2ec9e67dd497b87ada25080 /src/target/target.c | |
parent | f30136603e4cc8b2db0112a32f26959d5201e58c (diff) |
target: make "examined" flag be per-target
Previously this flag was stored in "target_type", so that for example
if there were two ARM7TDMI targets in a scan chain, both would claim
to have been examined although only the first one actually had its
examine() method called.
Move this state to where it should have been in the first place, and
hide a method that didn't need exposure ... the flag is write-once.
Provide some doxygen. The examine() method is confusing, since it
isn't separating one-time setup from the after-each-reset stuff. And
the ARM7/ARM9 version is, somewhat undesirably, not leaving the debug
state alone after reset ... probably more of an issue for trace setup
than for watchpoints and breakpoints.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Diffstat (limited to 'src/target/target.c')
-rw-r--r-- | src/target/target.c | 19 |
1 files changed, 6 insertions, 13 deletions
diff --git a/src/target/target.c b/src/target/target.c index 2385d0f6..f7e2ad64 100644 --- a/src/target/target.c +++ b/src/target/target.c @@ -644,20 +644,13 @@ int target_run_algorithm(struct target *target, entry_point, exit_point, timeout_ms, arch_info); } -/// @returns @c true if the target has been examined. -bool target_was_examined(struct target *target) -{ - return target->type->examined; -} -/// Sets the @c examined flag for the given target. -void target_set_examined(struct target *target) -{ - target->type->examined = true; -} -// Reset the @c examined flag for the given target. -void target_reset_examined(struct target *target) +/** + * Reset the @c examined flag for the given target. + * Pure paranoia -- targets are zeroed on allocation. + */ +static void target_reset_examined(struct target *target) { - target->type->examined = false; + target->examined = false; } |