diff options
| author | Mathias K <kesmtp@freenet.de> | 2011-12-16 07:48:39 +0100 |
|---|---|---|
| committer | Øyvind Harboe <oyvindharboe@gmail.com> | 2012-01-04 17:56:46 +0000 |
| commit | 16b6b5e7a86353dbc0c4823fe3d772c0faca7c1c (patch) | |
| tree | 4950e26d07d60b16b3223e085227c583418c2ef8 /src/target/etm.c | |
| parent | 42cb62cf3b47b982d6444948b483f9c6ce32de05 (diff) | |
Change return value on error.
On wrong parameters a error is signalized to the calling function.
Change-Id: I484443fdb39938e20382edc9246d5ec546a5c960
Signed-off-by: Mathias K <kesmtp@freenet.de>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/282
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Diffstat (limited to 'src/target/etm.c')
| -rw-r--r-- | src/target/etm.c | 19 |
1 files changed, 5 insertions, 14 deletions
diff --git a/src/target/etm.c b/src/target/etm.c index cd50e44d..27983698 100644 --- a/src/target/etm.c +++ b/src/target/etm.c @@ -1268,13 +1268,7 @@ COMMAND_HANDLER(handle_etm_tracemode_command) &tracemode); break; default: - command_print(CMD_CTX, "usage: tracemode " - "('none'|'data'|'address'|'all') " - "context_id_bits " - "('enable'|'disable') " - "('enable'|'disable')" - ); - return ERROR_FAIL; + return ERROR_COMMAND_SYNTAX_ERROR; } /** @@ -1738,8 +1732,7 @@ COMMAND_HANDLER(handle_etm_image_command) if (CMD_ARGC < 1) { - command_print(CMD_CTX, "usage: etm image <file> [base address] [type]"); - return ERROR_FAIL; + return ERROR_COMMAND_SYNTAX_ERROR; } target = get_current_target(CMD_CTX); @@ -1799,8 +1792,7 @@ COMMAND_HANDLER(handle_etm_dump_command) if (CMD_ARGC != 1) { - command_print(CMD_CTX, "usage: etm dump <file>"); - return ERROR_FAIL; + return ERROR_COMMAND_SYNTAX_ERROR; } target = get_current_target(CMD_CTX); @@ -1866,8 +1858,7 @@ COMMAND_HANDLER(handle_etm_load_command) if (CMD_ARGC != 1) { - command_print(CMD_CTX, "usage: etm load <file>"); - return ERROR_FAIL; + return ERROR_COMMAND_SYNTAX_ERROR; } target = get_current_target(CMD_CTX); @@ -2206,7 +2197,7 @@ static const struct command_registration etm_exec_command_handlers[] = { .handler = handle_etm_image_command, .mode = COMMAND_EXEC, .help = "load image from file with optional offset", - .usage = "filename [offset]", + .usage = "<file> [base address] [type]", }, { .name = "dump", |