diff options
author | David Brownell <dbrownell@users.sourceforge.net> | 2009-11-05 21:59:39 -0800 |
---|---|---|
committer | David Brownell <dbrownell@users.sourceforge.net> | 2009-11-05 21:59:39 -0800 |
commit | db116b1ea3c77a3c5850fccbce9e0795faa21dda (patch) | |
tree | 9c9f456f726fe99b098324750b6942bf6c2bd497 /src/target/cortex_a8.h | |
parent | b7e4c26b9bb10e6e0ebfb07e5d43f0d62526cde2 (diff) |
target: provide container_of()
Provide a cleaner way to handle single inheritance of targets
in C, using the same model Linux does: structs containing other
structs, un-nested via calls to a "container_of()" macro that
are packaged in typesafe inline functions.
Targets already use this containment idiom, but make it much
more complicated because they un-nest using embedded "void *"
pointers ... in chains of up to five per target, which is all
pure needless complication. (Example: arm92x core, arm9tdmi,
arm7_9, armv4_5 ... on top of the base "target" class.)
Applying this scheme consistently simplifies things, and gets
rid of many error-prone untyped pointers. It won't change any
part of the type model though -- it just simplifies things.
(And facilitates more cleanup later on.)
Rule of thumb: where there's an X->arch_info void* pointer,
access to that pointer can and should be removed. It may be
convenient to set up pointers to some of the embedded structs;
and shrink their current "*_common" names (annoyingly long).
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Diffstat (limited to 'src/target/cortex_a8.h')
-rw-r--r-- | src/target/cortex_a8.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/target/cortex_a8.h b/src/target/cortex_a8.h index 36956964..b98a7de1 100644 --- a/src/target/cortex_a8.h +++ b/src/target/cortex_a8.h @@ -137,6 +137,13 @@ typedef struct cortex_a8_common_s void *arch_info; } cortex_a8_common_t; +static inline struct cortex_a8_common_s * +target_to_cortex_a8(struct target_s *target) +{ + return container_of(target->arch_info, struct cortex_a8_common_s, + armv7a_common.armv4_5_common); +} + extern int cortex_a8_init_arch_info(target_t *target, cortex_a8_common_t *cortex_a8, jtag_tap_t *tap); int cortex_a8_read_memory(struct target_s *target, uint32_t address, uint32_t size, uint32_t count, uint8_t *buffer); int cortex_a8_write_memory(struct target_s *target, uint32_t address, uint32_t size, uint32_t count, uint8_t *buffer); |