diff options
| author | Michel Jaouen <michel.jaouen@stericsson.com> | 2011-10-03 19:05:59 +0200 |
|---|---|---|
| committer | Spencer Oliver <spen@spen-soft.co.uk> | 2011-10-13 18:54:04 +0000 |
| commit | 5a7cff26a502ecc5dbd027ebb9d28d95782681a8 (patch) | |
| tree | e428a9a3fd6e6610b2ac953bc9da3d2919ae4436 /src/target/breakpoints.c | |
| parent | 2c6d312ec9e1aec514e80b7c317ed93d72197ba2 (diff) | |
breakpoint : smp software breakpoint issue
Change-Id: Iefe78bad71d4fdb38ae412ab8fe2f6282836c22e
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/14
Tested-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Diffstat (limited to 'src/target/breakpoints.c')
| -rw-r--r-- | src/target/breakpoints.c | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/src/target/breakpoints.c b/src/target/breakpoints.c index e722f67e..c0905ede 100644 --- a/src/target/breakpoints.c +++ b/src/target/breakpoints.c @@ -228,6 +228,9 @@ int breakpoint_add(struct target *target, uint32_t address, uint32_t length, enu struct target_list *head; struct target *curr; head = target->head; + if (type == BKPT_SOFT) + return(breakpoint_add_internal(head->target, address,length, type)); + while(head != (struct target_list*)NULL) { curr = head->target; @@ -312,7 +315,7 @@ static void breakpoint_free(struct target *target, struct breakpoint *breakpoint free(breakpoint); } -void breakpoint_remove_internal(struct target *target, uint32_t address) +int breakpoint_remove_internal(struct target *target, uint32_t address) { struct breakpoint *breakpoint = target->breakpoints; @@ -330,14 +333,18 @@ void breakpoint_remove_internal(struct target *target, uint32_t address) if (breakpoint) { breakpoint_free(target, breakpoint); + return 1; } else { - LOG_ERROR("no breakpoint at address 0x%8.8" PRIx32 " found", address); + if (!target->smp) + LOG_ERROR("no breakpoint at address 0x%8.8" PRIx32 " found", address); + return 0; } } void breakpoint_remove(struct target *target, uint32_t address) { + int found = 0; if (target->smp) { struct target_list *head; @@ -346,9 +353,11 @@ void breakpoint_remove(struct target *target, uint32_t address) while(head != (struct target_list*)NULL) { curr = head->target; - breakpoint_remove_internal(curr, address); + found += breakpoint_remove_internal(curr, address); head = head->next; } + if (found == 0) + LOG_ERROR("no breakpoint at address 0x%8.8" PRIx32 " found", address); } else breakpoint_remove_internal(target, address); } |