diff options
| author | Andreas Fritiofson <andreas.fritiofson@gmail.com> | 2013-11-07 00:40:50 +0100 |
|---|---|---|
| committer | Spencer Oliver <spen@spen-soft.co.uk> | 2014-01-20 13:28:26 +0000 |
| commit | 63fa73169bd88258ef82f709e79769eacc50f793 (patch) | |
| tree | 5f259281041de2aa5d7097db46a64d4175279a96 /src/target/arm_jtag.c | |
| parent | 87e91f4db9bea66a7866261130c6152c0304bc29 (diff) | |
Retire jtag_add_dr_out
The out only version of jtag_add_dr_scan smells like a bogus optimization
that complicates the minidriver API for questionable gain.
The function was only used by four old ARM targets. Rewrite the callers
to use the generic function and remove all implementations.
Change-Id: I13b643687ee8ed6bc9b6336e7096c34f40ea96af
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1801
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Diffstat (limited to 'src/target/arm_jtag.c')
| -rw-r--r-- | src/target/arm_jtag.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/src/target/arm_jtag.c b/src/target/arm_jtag.c index 1739a8a9..6f70e853 100644 --- a/src/target/arm_jtag.c +++ b/src/target/arm_jtag.c @@ -59,20 +59,18 @@ int arm_jtag_set_instr_inner(struct arm_jtag *jtag_info, int arm_jtag_scann_inner(struct arm_jtag *jtag_info, uint32_t new_scan_chain, tap_state_t end_state) { int retval = ERROR_OK; - uint32_t values[1]; - int num_bits[1]; - values[0] = new_scan_chain; - num_bits[0] = jtag_info->scann_size; + uint8_t out_value[4]; + buf_set_u32(out_value, 0, jtag_info->scann_size, new_scan_chain); + struct scan_field field = { .num_bits = jtag_info->scann_size, .out_value = out_value, }; retval = arm_jtag_set_instr(jtag_info, jtag_info->scann_instr, NULL, end_state); if (retval != ERROR_OK) return retval; - jtag_add_dr_out(jtag_info->tap, + jtag_add_dr_scan(jtag_info->tap, 1, - num_bits, - values, + &field, end_state); jtag_info->cur_scan_chain = new_scan_chain; |