diff options
author | Andreas Fritiofson <andreas.fritiofson@gmail.com> | 2012-08-22 19:42:02 +0200 |
---|---|---|
committer | Freddie Chopin <freddie.chopin@gmail.com> | 2012-08-29 06:23:47 +0000 |
commit | 0989cd4d5d69850df38122f9ba1e7d5b4009fb51 (patch) | |
tree | 53c16a14d8f5146b72f1ac79fdf76c2b8b717e0c /src/target/arm.h | |
parent | 47728f92159e11668a4aa1ec3d2713ee38a87192 (diff) |
arm7_9: Fix broken halfword/byte memory reads
Always scan out all bits, but make sure only the allowed number of bytes
end up in the caller-provided buffer. Discard the rest by adding another
scan field when size < 4.
Rewrite the endianness callback to avoid reading outside allocated memory.
Make it directly usable as a callback without the need for a wrapper. Move
the shared callback to a more suitable home in arm7_9_common.
This fixes the regressions introduced in commits
991ed5a2b657e660f744eefddb084724e52938ea
cb90d32e386a7489d31136997209c61e9559ff5e
and
c3074f377c1da33ca8ba8493826e1b52351eebc6
Change-Id: Ia8bde8c5a9844e89a1d6c0bc8534cd26f02f8d11
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/789
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-by: Freddie Chopin <freddie.chopin@gmail.com>
Diffstat (limited to 'src/target/arm.h')
-rw-r--r-- | src/target/arm.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/target/arm.h b/src/target/arm.h index 30e2c76e..916b321e 100644 --- a/src/target/arm.h +++ b/src/target/arm.h @@ -237,8 +237,6 @@ int arm_blank_check_memory(struct target *target, void arm_set_cpsr(struct arm *arm, uint32_t cpsr); struct reg *arm_reg_current(struct arm *arm, unsigned regnum); -void arm_endianness(uint8_t *tmp, void *in, int size, int be, int flip); - extern struct reg arm_gdb_dummy_fp_reg; extern struct reg arm_gdb_dummy_fps_reg; |