diff options
author | Paul Fertser <fercerpav@gmail.com> | 2015-02-15 21:37:16 +0300 |
---|---|---|
committer | Paul Fertser <fercerpav@gmail.com> | 2015-03-09 06:38:52 +0000 |
commit | d019080dfaa6c0c49228ecec2ad0c585ac65cb73 (patch) | |
tree | ac441b70247da086791c411b34c0440cfa62650f /src/jtag/drivers/stlink_usb.c | |
parent | b4b1976e4e01bdc0b33312cda593d7593bae30a9 (diff) |
stlink: avoid null pointer dereference in stlink_usb_close()
Otherwise it happens if stlink can not be opened on start.
Change-Id: I7088f10e61508dae230eccfe576a51498c92f5b8
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/2550
Tested-by: jenkins
Reviewed-by: Andreas Färber <afaerber@suse.de>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-by: Stian Skjelstad <stian@nixia.no>
Diffstat (limited to 'src/jtag/drivers/stlink_usb.c')
-rw-r--r-- | src/jtag/drivers/stlink_usb.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/jtag/drivers/stlink_usb.c b/src/jtag/drivers/stlink_usb.c index 4959f97c..554ffc1e 100644 --- a/src/jtag/drivers/stlink_usb.c +++ b/src/jtag/drivers/stlink_usb.c @@ -1664,14 +1664,14 @@ static int stlink_speed(void *handle, int khz, bool query) } /** */ -static int stlink_usb_close(void *fd) +static int stlink_usb_close(void *handle) { - struct stlink_usb_handle_s *h = fd; + struct stlink_usb_handle_s *h = handle; - if (h->fd) + if (h && h->fd) jtag_libusb_close(h->fd); - free(fd); + free(h); return ERROR_OK; } |