diff options
| author | Paul Fertser <fercerpav@gmail.com> | 2015-01-17 15:15:11 +0300 |
|---|---|---|
| committer | Paul Fertser <fercerpav@gmail.com> | 2015-01-30 08:56:54 +0000 |
| commit | 355f4cadbbf10c75cf05fb1a82bf918b3ab65c55 (patch) | |
| tree | f874ce4af77346c82220be72f217b2b311cff380 /src/jtag/drivers/ftdi.c | |
| parent | 9d745a0690f6f5c24d914ebfa3c1d6b824a19a5e (diff) | |
Use (uint8_t *) for buf_(set|get)_u(32|64) instead of (void *)
This helps to uncover incorrect usage when a pointer to uint32_t is
passed to those functions which leads to subtle bugs on BE systems.
The reason is that it's normally assumed that any uint32_t variable
holds its value in host byte order, but using but_set_u32 on it
silently does implicit pointer conversion to (void *) and the
assumption ends up broken without any indication.
Change-Id: I48ffd190583d8aa32ec1fef8f1cdc0b4184e4546
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/2467
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Diffstat (limited to 'src/jtag/drivers/ftdi.c')
| -rw-r--r-- | src/jtag/drivers/ftdi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/jtag/drivers/ftdi.c b/src/jtag/drivers/ftdi.c index c031fd36..7df6389e 100644 --- a/src/jtag/drivers/ftdi.c +++ b/src/jtag/drivers/ftdi.c @@ -965,7 +965,7 @@ static int ftdi_swd_run_queue(struct adiv5_dap *dap) } for (size_t i = 0; i < swd_cmd_queue_length; i++) { - int ack = buf_get_u32(&swd_cmd_queue[i].trn_ack_data_parity_trn, 1, 3); + int ack = buf_get_u32(swd_cmd_queue[i].trn_ack_data_parity_trn, 1, 3); LOG_DEBUG("%s %s %s reg %X = %08"PRIx32, ack == SWD_ACK_OK ? "OK" : ack == SWD_ACK_WAIT ? "WAIT" : ack == SWD_ACK_FAULT ? "FAULT" : "JUNK", |