diff options
| author | Mathias K <kesmtp@freenet.de> | 2011-12-16 07:48:39 +0100 |
|---|---|---|
| committer | Øyvind Harboe <oyvindharboe@gmail.com> | 2012-01-04 17:56:46 +0000 |
| commit | 16b6b5e7a86353dbc0c4823fe3d772c0faca7c1c (patch) | |
| tree | 4950e26d07d60b16b3223e085227c583418c2ef8 /src/jtag/drivers/buspirate.c | |
| parent | 42cb62cf3b47b982d6444948b483f9c6ce32de05 (diff) | |
Change return value on error.
On wrong parameters a error is signalized to the calling function.
Change-Id: I484443fdb39938e20382edc9246d5ec546a5c960
Signed-off-by: Mathias K <kesmtp@freenet.de>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/282
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Diffstat (limited to 'src/jtag/drivers/buspirate.c')
| -rw-r--r-- | src/jtag/drivers/buspirate.c | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/src/jtag/drivers/buspirate.c b/src/jtag/drivers/buspirate.c index 41e3e194..f3edc8a5 100644 --- a/src/jtag/drivers/buspirate.c +++ b/src/jtag/drivers/buspirate.c @@ -280,8 +280,7 @@ COMMAND_HANDLER(buspirate_handle_adc_command) COMMAND_HANDLER(buspirate_handle_vreg_command) { if (CMD_ARGC < 1) { - LOG_ERROR("usage: buspirate_vreg <1|0>"); - return ERROR_OK; + return ERROR_COMMAND_SYNTAX_ERROR; } if (atoi(CMD_ARGV[0]) == 1) @@ -298,8 +297,7 @@ COMMAND_HANDLER(buspirate_handle_vreg_command) COMMAND_HANDLER(buspirate_handle_pullup_command) { if (CMD_ARGC < 1) { - LOG_ERROR("usage: buspirate_pullup <1|0>"); - return ERROR_OK; + return ERROR_COMMAND_SYNTAX_ERROR; } if (atoi(CMD_ARGV[0]) == 1) @@ -316,8 +314,7 @@ COMMAND_HANDLER(buspirate_handle_pullup_command) COMMAND_HANDLER(buspirate_handle_led_command) { if (CMD_ARGC < 1) { - LOG_ERROR("usage: buspirate_led <1|0>"); - return ERROR_OK; + return ERROR_COMMAND_SYNTAX_ERROR; } if (atoi(CMD_ARGV[0]) == 1) { @@ -339,8 +336,7 @@ COMMAND_HANDLER(buspirate_handle_led_command) COMMAND_HANDLER(buspirate_handle_mode_command) { if (CMD_ARGC < 1) { - LOG_ERROR("usage: buspirate_mode <normal|open-drain>"); - return ERROR_OK; + return ERROR_COMMAND_SYNTAX_ERROR; } if (CMD_ARGV[0][0] == 'n') @@ -357,8 +353,7 @@ COMMAND_HANDLER(buspirate_handle_mode_command) COMMAND_HANDLER(buspirate_handle_speed_command) { if (CMD_ARGC < 1) { - LOG_ERROR("usage: buspirate_speed <normal|fast>"); - return ERROR_OK; + return ERROR_COMMAND_SYNTAX_ERROR; } if (CMD_ARGV[0][0] == 'n') @@ -375,8 +370,7 @@ COMMAND_HANDLER(buspirate_handle_speed_command) COMMAND_HANDLER(buspirate_handle_port_command) { if (CMD_ARGC < 1) { - LOG_ERROR("usage: buspirate_port /dev/ttyUSB0"); - return ERROR_OK; + return ERROR_COMMAND_SYNTAX_ERROR; } if (buspirate_port == NULL) @@ -395,36 +389,42 @@ static const struct command_registration buspirate_command_handlers[] = { }, { .name = "buspirate_vreg", + .usage = "<1|0>", .handler = &buspirate_handle_vreg_command, .mode = COMMAND_CONFIG, .help = "changes the state of voltage regulators", }, { .name = "buspirate_pullup", + .usage = "<1|0>", .handler = &buspirate_handle_pullup_command, .mode = COMMAND_CONFIG, .help = "changes the state of pullup", }, { .name = "buspirate_led", + .usage = "<1|0>", .handler = &buspirate_handle_led_command, .mode = COMMAND_EXEC, .help = "changes the state of led", }, { .name = "buspirate_speed", + .usage = "<normal|fast>", .handler = &buspirate_handle_speed_command, .mode = COMMAND_CONFIG, .help = "speed of the interface", }, { .name = "buspirate_mode", + .usage = "<normal|open-drain>", .handler = &buspirate_handle_mode_command, .mode = COMMAND_CONFIG, .help = "pin mode of the interface", }, { .name = "buspirate_port", + .usage = "/dev/ttyUSB0", .handler = &buspirate_handle_port_command, .mode = COMMAND_CONFIG, .help = "name of the serial port to open", |