diff options
| author | Antonio Borneo <borneo.antonio@gmail.com> | 2019-04-07 12:18:05 +0200 |
|---|---|---|
| committer | Tomas Vanek <vanekt@fbl.cz> | 2019-05-23 22:13:09 +0100 |
| commit | f912649968c2333a7a1d19aa7106e900b3d8527a (patch) | |
| tree | 95ca2eac97a6c740137bbe27324b0ee7321e9e6f /src/helper/command.c | |
| parent | 5fbf4d4cc3f67ec8b2fb3d8a789117583a84e1a1 (diff) | |
helper/command: remove dead code in command_unknown()
Commit 89fa493a3bc34d22eeca06fa4e78523ac3b766a8 removes the top
level command "unknown" and adds in command_unknown() some unclear
code that should detect a user-implemented "unknown" command.
But, all the commands that trigger the execution of the function
command_unknown() are registered in register_command_handler() and
have the command name prefixed with "ocd_".
Due to such "ocd_" prefix in cmd_name, the condition
if (strcmp(cmd_name, "unknown") == 0) { ... }
is always false.
Nobody complained for almost 10 years so we can proceed to remove
this dead code, before merging any change that obsoletes the
prefix "ocd_" and potentially makes the condition true.
Remove the dead code guarded by the condition above.
Change-Id: Icf11a956bb2d68fc84e6eb5779edf8e35db8fa53
Fixes: 89fa493a3bc3 ("remove unknown handler")
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5096
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Diffstat (limited to 'src/helper/command.c')
| -rw-r--r-- | src/helper/command.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/helper/command.c b/src/helper/command.c index 3346a6c3..ab0654b6 100644 --- a/src/helper/command.c +++ b/src/helper/command.c @@ -1028,12 +1028,6 @@ static int run_usage(Jim_Interp *interp, int argc_valid, int argc, Jim_Obj * con static int command_unknown(Jim_Interp *interp, int argc, Jim_Obj *const *argv) { const char *cmd_name = Jim_GetString(argv[0], NULL); - if (strcmp(cmd_name, "unknown") == 0) { - if (argc == 1) - return JIM_OK; - argc--; - argv++; - } script_debug(interp, cmd_name, argc, argv); struct command_context *cmd_ctx = current_command_context(interp); |