diff options
| author | Mathias K <kesmtp@freenet.de> | 2011-12-16 07:48:39 +0100 |
|---|---|---|
| committer | Øyvind Harboe <oyvindharboe@gmail.com> | 2012-01-04 17:56:46 +0000 |
| commit | 16b6b5e7a86353dbc0c4823fe3d772c0faca7c1c (patch) | |
| tree | 4950e26d07d60b16b3223e085227c583418c2ef8 /src/flash/nor/em357.c | |
| parent | 42cb62cf3b47b982d6444948b483f9c6ce32de05 (diff) | |
Change return value on error.
On wrong parameters a error is signalized to the calling function.
Change-Id: I484443fdb39938e20382edc9246d5ec546a5c960
Signed-off-by: Mathias K <kesmtp@freenet.de>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/282
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Diffstat (limited to 'src/flash/nor/em357.c')
| -rw-r--r-- | src/flash/nor/em357.c | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/src/flash/nor/em357.c b/src/flash/nor/em357.c index c400187d..c045d577 100644 --- a/src/flash/nor/em357.c +++ b/src/flash/nor/em357.c @@ -104,8 +104,7 @@ FLASH_BANK_COMMAND_HANDLER(em357_flash_bank_command) if (CMD_ARGC < 6) { - LOG_WARNING("incomplete flash_bank em357 configuration"); - return ERROR_FLASH_BANK_INVALID; + return ERROR_COMMAND_SYNTAX_ERROR; } em357_info = malloc(sizeof(struct em357_flash_bank)); @@ -768,8 +767,7 @@ COMMAND_HANDLER(em357_handle_lock_command) if (CMD_ARGC < 1) { - command_print(CMD_CTX, "em357 lock <bank>"); - return ERROR_OK; + return ERROR_COMMAND_SYNTAX_ERROR; } struct flash_bank *bank; @@ -813,8 +811,7 @@ COMMAND_HANDLER(em357_handle_unlock_command) if (CMD_ARGC < 1) { - command_print(CMD_CTX, "em357 unlock <bank>"); - return ERROR_OK; + return ERROR_COMMAND_SYNTAX_ERROR; } struct flash_bank *bank; @@ -892,8 +889,7 @@ COMMAND_HANDLER(em357_handle_mass_erase_command) if (CMD_ARGC < 1) { - command_print(CMD_CTX, "em357 mass_erase <bank>"); - return ERROR_OK; + return ERROR_COMMAND_SYNTAX_ERROR; } struct flash_bank *bank; @@ -923,23 +919,23 @@ COMMAND_HANDLER(em357_handle_mass_erase_command) static const struct command_registration em357_exec_command_handlers[] = { { .name = "lock", + .usage = "<bank>", .handler = em357_handle_lock_command, .mode = COMMAND_EXEC, - .usage = "bank_id", .help = "Lock entire flash device.", }, { .name = "unlock", + .usage = "<bank>", .handler = em357_handle_unlock_command, .mode = COMMAND_EXEC, - .usage = "bank_id", .help = "Unlock entire protected flash device.", }, { .name = "mass_erase", + .usage = "<bank>", .handler = em357_handle_mass_erase_command, .mode = COMMAND_EXEC, - .usage = "bank_id", .help = "Erase entire flash device.", }, COMMAND_REGISTRATION_DONE |