diff options
author | Zachary T Welch <zw@superlucidity.net> | 2009-11-13 14:44:53 -0800 |
---|---|---|
committer | Zachary T Welch <zw@superlucidity.net> | 2009-11-16 15:47:09 -0800 |
commit | 51862bb98c26e9b3f03d46ae0f8ceb434f0743d0 (patch) | |
tree | 78cb65e732581369d51937ca7ba1de670313f016 /src/flash/nand.c | |
parent | 69df712d1d06b2c698bed3de086b9f734de73b7e (diff) |
fileio: improve API types
Use size_t instead of uint32_t when specifying file sizes. Update all
consumers up through the layers to use size_t when required. These
changes should be safe, but the higher-levels will need to be updated
further to receive the intended benefits (i.e. large file support).
Add error checking for fileio_read and file_write. Previously, all
errors were being silently ignored, so this change might cause some
problems for some people in some cases. However, it gives us the chance
to handle any errors that do occur at higher-levels, rather than burying
our heads in the sand.
Diffstat (limited to 'src/flash/nand.c')
-rw-r--r-- | src/flash/nand.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/flash/nand.c b/src/flash/nand.c index 9d997fad..71a67c45 100644 --- a/src/flash/nand.c +++ b/src/flash/nand.c @@ -1453,8 +1453,8 @@ static COMMAND_HELPER(nand_fileio_parse_args, struct nand_fileio_state *state, static int nand_fileio_read(struct nand_device *nand, struct nand_fileio_state *s) { - uint32_t total_read = 0; - uint32_t one_read; + size_t total_read = 0; + size_t one_read; if (NULL != s->page) { @@ -1616,7 +1616,7 @@ COMMAND_HANDLER(handle_nand_dump_command) while (s.size > 0) { - uint32_t size_written; + size_t size_written; int retval = nand_read_page(nand, s.address / nand->page_size, s.page, s.page_size, s.oob, s.oob_size); if (ERROR_OK != retval) |