diff options
| author | Freddie Chopin <freddie.chopin@gmail.com> | 2012-07-17 09:49:37 +0200 |
|---|---|---|
| committer | Øyvind Harboe <oyvindharboe@gmail.com> | 2013-02-28 06:22:51 +0000 |
| commit | 57aa19f8460682a41f87b9f7d685278775fff6db (patch) | |
| tree | ec5e19cfeedbcf7adf057b0ac53ab5289f86d106 | |
| parent | 3d62c3df6ddb09f1485c25d665e248856989d180 (diff) | |
Update HACKING info
Inform about possibility of discarding negative review in Gerrit when specific conditions are met.
Change-Id: I432b6c93cefc368fa22ce1096bea4cd174e03816
Signed-off-by: Freddie Chopin <freddie.chopin@gmail.com>
Reviewed-on: http://openocd.zylin.com/747
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Tested-by: Øyvind Harboe <oyvindharboe@gmail.com>
| -rw-r--r-- | HACKING | 7 |
1 files changed, 7 insertions, 0 deletions
@@ -152,6 +152,13 @@ master branch will be much reduced. If a contributor pushes a patch, it is considered good form if another contributor actually approves and submits that patch. +It should be noted that a negative review in Gerrit ("-1" or "-2") may (but does +not have to) be disregarded if all conditions listed below are met: + +- the concerns raised in the review have been addressed (or explained), +- reviewer does not re-examine the change in a month, +- reviewer does not answer e-mails for another month. + @section browsing Browsing Patches All OpenOCD patches can be reviewed <a href="http://openocd.zylin.com/">here</a>. */ |