From 74b0ccc577062a25b8b3ab99b13cd1efa6e3a75a Mon Sep 17 00:00:00 2001 From: Bob Wilson Date: Tue, 12 May 2009 03:48:10 +0000 Subject: Fix pr4195: When iterating through predecessor blocks, break out of the loop after finding the (unique) layout predecessor. Sometimes a block may be listed more than once, and processing it more than once in this loop can lead to inconsistent values for FtTBB/FtFBB, since the AnalyzeBranch method does not clear these values. There's no point in continuing the loop regardless. The testcase for this is reduced from the 2003-05-02-DependentPHI SingleSource test. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@71536 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/CodePlacementOpt.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'lib/CodeGen/CodePlacementOpt.cpp') diff --git a/lib/CodeGen/CodePlacementOpt.cpp b/lib/CodeGen/CodePlacementOpt.cpp index 77d23eed6c..2e1d12d234 100644 --- a/lib/CodeGen/CodePlacementOpt.cpp +++ b/lib/CodeGen/CodePlacementOpt.cpp @@ -155,10 +155,10 @@ bool CodePlacementOpt::OptimizeIntraLoopEdges() { // A fallthrough. FtMBB = PredMBB; MachineLoop *PL = MLI->getLoopFor(PredMBB); - if (PL && (PL == L || PL->getLoopDepth() >= L->getLoopDepth())) { + if (PL && (PL == L || PL->getLoopDepth() >= L->getLoopDepth())) OkToMove = false; - break; - } + + break; } } -- cgit v1.2.3-18-g5258