From ba6de4b1cf6057f9b62d785b2e8e70a469ce25d7 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Fri, 9 Feb 2007 07:51:47 +0000 Subject: 1. constants can never occur in the symbol table. 2. All function-level constants are now incorporated into the module-level constant pool, since the compaction table was removed. Eliminate extra work to check for them. This speeds up the bcwriter from 24.4s to 13.1s on 447.dealII and .73 -> .56s on kc++ in a release build. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@34084 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Bytecode/Writer/SlotCalculator.cpp | 18 ------------------ 1 file changed, 18 deletions(-) (limited to 'lib/Bytecode/Writer/SlotCalculator.cpp') diff --git a/lib/Bytecode/Writer/SlotCalculator.cpp b/lib/Bytecode/Writer/SlotCalculator.cpp index 197f20601a..478216d145 100644 --- a/lib/Bytecode/Writer/SlotCalculator.cpp +++ b/lib/Bytecode/Writer/SlotCalculator.cpp @@ -171,7 +171,6 @@ void SlotCalculator::processModule() { } getOrCreateSlot(I->getType()); } - processSymbolTableConstants(&F->getValueSymbolTable()); } // Insert constants that are named at module level into the slot pool so that @@ -233,15 +232,6 @@ void SlotCalculator::processValueSymbolTable(const ValueSymbolTable *VST) { getOrCreateSlot(VI->second); } -void SlotCalculator::processSymbolTableConstants(const ValueSymbolTable *VST) { - // Now do the constant values in all planes - for (ValueSymbolTable::const_iterator VI = VST->begin(), VE = VST->end(); - VI != VE; ++VI) - if (isa(VI->second) && !isa(VI->second)) - getOrCreateSlot(VI->second); -} - - void SlotCalculator::incorporateFunction(const Function *F) { assert((ModuleLevel.empty() || ModuleTypeLevel == 0) && "Module already incorporated!"); @@ -270,14 +260,6 @@ void SlotCalculator::incorporateFunction(const Function *F) { for (constant_iterator CI = constant_begin(F), CE = constant_end(F); CI != CE; ++CI) getOrCreateSlot(*CI); - - // If there is a symbol table, it is possible that the user has names for - // constants that are not being used. In this case, we will have problems - // if we don't emit the constants now, because otherwise we will get - // symbol table references to constants not in the output. Scan for these - // constants now. - // - processSymbolTableConstants(&F->getValueSymbolTable()); } SC_DEBUG("Inserting Instructions:\n"); -- cgit v1.2.3-70-g09d2