From bcb11cf13209d5aa32cbbf82cc266d202163739e Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Tue, 27 Jul 2004 02:34:49 +0000 Subject: Simplify code and silence warning git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@15255 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Bytecode/Reader/Reader.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'lib/Bytecode/Reader/Reader.cpp') diff --git a/lib/Bytecode/Reader/Reader.cpp b/lib/Bytecode/Reader/Reader.cpp index 6da38dd6c7..3ebd7c88f4 100644 --- a/lib/Bytecode/Reader/Reader.cpp +++ b/lib/Bytecode/Reader/Reader.cpp @@ -1401,16 +1401,14 @@ Constant *BytecodeReader::ParseConstantValue(unsigned TypeID) { // Check to see if we have already read this global variable... Value *Val = getValue(TypeID, Slot, false); - GlobalValue *GV; if (Val) { - if (!(GV = dyn_cast(Val))) - error("GlobalValue not in ValueTable!"); + GlobalValue *GV = dyn_cast(Val); + if (!GV) error("GlobalValue not in ValueTable!"); + if (Handler) Handler->handleConstantPointer(PT, Slot, GV); + return GV; } else { error("Forward references are not allowed here."); } - - if (Handler) Handler->handleConstantPointer(PT, Slot, GV ); - return GV; } default: -- cgit v1.2.3-18-g5258