aboutsummaryrefslogtreecommitdiff
path: root/unittests
diff options
context:
space:
mode:
authorDaniel Dunbar <daniel@zuster.org>2009-07-12 19:45:34 +0000
committerDaniel Dunbar <daniel@zuster.org>2009-07-12 19:45:34 +0000
commit614be08dd6ae0755d8a4c32ad49f5f580602cc78 (patch)
tree239d9a7caabe4ee1a3fc0c506b2d816148491c9f /unittests
parent0f55014430b92e3859aef60e0e4772364b232840 (diff)
Clarify a FIXME.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@75422 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'unittests')
-rw-r--r--unittests/ADT/SmallVectorTest.cpp9
1 files changed, 5 insertions, 4 deletions
diff --git a/unittests/ADT/SmallVectorTest.cpp b/unittests/ADT/SmallVectorTest.cpp
index 19ef099224..addd904361 100644
--- a/unittests/ADT/SmallVectorTest.cpp
+++ b/unittests/ADT/SmallVectorTest.cpp
@@ -196,7 +196,8 @@ TEST_F(SmallVectorTest, ResizeGrowTest) {
theVector.resize(2);
- // XXX: I don't know where the extra construct/destruct is coming from.
+ // The extra constructor/destructor calls come from the temporary object used
+ // to initialize the contents of the resized array (via copy construction).
EXPECT_EQ(3, Constructable::getNumConstructorCalls());
EXPECT_EQ(1, Constructable::getNumDestructorCalls());
EXPECT_EQ(2u, theVector.size());
@@ -214,16 +215,16 @@ TEST_F(SmallVectorTest, ResizeFillTest) {
TEST_F(SmallVectorTest, OverflowTest) {
SCOPED_TRACE("OverflowTest");
- // Push more elements than the fixed size
+ // Push more elements than the fixed size.
makeSequence(theVector, 1, 10);
- // test size and values
+ // Test size and values.
EXPECT_EQ(10u, theVector.size());
for (int i = 0; i < 10; ++i) {
EXPECT_EQ(i+1, theVector[i].getValue());
}
- // Now resize back to fixed size
+ // Now resize back to fixed size.
theVector.resize(1);
assertValuesInOrder(theVector, 1u, 1);