diff options
author | Meador Inge <meadori@codesourcery.com> | 2013-03-12 00:08:29 +0000 |
---|---|---|
committer | Meador Inge <meadori@codesourcery.com> | 2013-03-12 00:08:29 +0000 |
commit | 67cb638629c69ab8c896175f58b4f472de5988d9 (patch) | |
tree | a47d6fe65f0ca4e0984cc1ef91cedc34d03e1f35 /test/CodeGen/X86/movgs.ll | |
parent | c0ec8a4f4db3c579dfc8c219dc39014f34260b42 (diff) |
LibCallSimplifier: optimize speed for short-lived instances
Nadav reported a performance regression due to the work I did to
merge the library call simplifier into instcombine [1]. The issue
is that a new LibCallSimplifier object is being created whenever
InstCombiner::runOnFunction is called. Every time a LibCallSimplifier
object is used to optimize a call it creates a hash table to map from
a function name to an object that optimizes functions of that name.
For short-lived LibCallSimplifier instances this is quite inefficient.
Especially for cases where no calls are actually simplified.
This patch fixes the issue by dropping the hash table and implementing
an explicit lookup function to correlate the function name to the object
that optimizes functions of that name. This avoids the cost of always
building and destroying the hash table in cases where the LibCallSimplifier
object is short-lived and avoids the cost of building the table when no
simplifications are actually preformed.
On a benchmark containing 100,000 calls where none of them are simplified
I noticed a 30% speedup. On a benchmark containing 100,000 calls where
all of them are simplified I noticed an 8% speedup.
[1] http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20130304/167639.html
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@176840 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/CodeGen/X86/movgs.ll')
0 files changed, 0 insertions, 0 deletions