diff options
author | Chris Lattner <sabre@nondot.org> | 2009-07-24 03:27:21 +0000 |
---|---|---|
committer | Chris Lattner <sabre@nondot.org> | 2009-07-24 03:27:21 +0000 |
commit | 083a1e059768f6844b9f5292223bb49ad24f52d1 (patch) | |
tree | c16c2854816b9543e014ff4a4e4ab052c6b072d7 /lib/VMCore/Constants.cpp | |
parent | ad733cd851efbb17cf3a4a70ec49acfc0f1c68fe (diff) |
make Constant::getRelocationInfo return an enum, as suggested by Duncan.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@76938 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/VMCore/Constants.cpp')
-rw-r--r-- | lib/VMCore/Constants.cpp | 23 |
1 files changed, 12 insertions, 11 deletions
diff --git a/lib/VMCore/Constants.cpp b/lib/VMCore/Constants.cpp index 74c31151ac..f94cd9e25f 100644 --- a/lib/VMCore/Constants.cpp +++ b/lib/VMCore/Constants.cpp @@ -107,22 +107,23 @@ bool Constant::canTrap() const { /// conservative, so if it might codegen to a relocatable entry, it should say /// so. The return values are: /// -/// 0: This constant pool entry is guaranteed to never have a relocation -/// applied to it (because it holds a simple constant like '4'). -/// 1: This entry has relocations, but the entries are guaranteed to be -/// resolvable by the static linker, so the dynamic linker will never see -/// them. -/// 2: This entry may have arbitrary relocations. +/// NoRelocation: This constant pool entry is guaranteed to never have a +/// relocation applied to it (because it holds a simple constant like +/// '4'). +/// LocalRelocation: This entry has relocations, but the entries are +/// guaranteed to be resolvable by the static linker, so the dynamic +/// linker will never see them. +/// GlobalRelocations: This entry may have arbitrary relocations. /// /// FIXME: This really should not be in VMCore. -unsigned Constant::getRelocationInfo() const { - if (const GlobalValue* GV = dyn_cast<GlobalValue>(this)) { +Constant::PossibleRelocationsTy Constant::getRelocationInfo() const { + if (const GlobalValue *GV = dyn_cast<GlobalValue>(this)) { if (GV->hasLocalLinkage() || GV->hasHiddenVisibility()) - return 1; // Local to this file/library. - return 2; // Global reference. + return LocalRelocation; // Local to this file/library. + return GlobalRelocations; // Global reference. } - unsigned Result = 0; + PossibleRelocationsTy Result = NoRelocation; for (unsigned i = 0, e = getNumOperands(); i != e; ++i) Result = std::max(Result, getOperand(i)->getRelocationInfo()); |