diff options
author | Evan Cheng <evan.cheng@apple.com> | 2010-04-07 06:00:33 +0000 |
---|---|---|
committer | Evan Cheng <evan.cheng@apple.com> | 2010-04-07 06:00:33 +0000 |
commit | 5b463905be11f8c89bf3a7a777eb5d0c7be7162d (patch) | |
tree | b9a20804d7a11362b00375220653919b84eaeabf /lib/CodeGen | |
parent | 348856e56a247c9815986be51565551394f9e9c2 (diff) |
Add comments for missed opportunities.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@100610 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen')
-rw-r--r-- | lib/CodeGen/MachineLICM.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/CodeGen/MachineLICM.cpp b/lib/CodeGen/MachineLICM.cpp index 72f7d4549c..0edd44ba2e 100644 --- a/lib/CodeGen/MachineLICM.cpp +++ b/lib/CodeGen/MachineLICM.cpp @@ -247,6 +247,8 @@ void MachineLICM::HoistRegionPostRA(MachineDomTreeNode *N) { if (!CurLoop->contains(BB)) continue; // Conservatively treat live-in's as an external def. + // FIXME: That means a reload that's reused into a fallthrough block + // will not be LICM'ed. for (MachineBasicBlock::const_livein_iterator I = BB->livein_begin(), E = BB->livein_end(); I != E; ++I) { unsigned Reg = *I; @@ -282,7 +284,8 @@ void MachineLICM::HoistRegionPostRA(MachineDomTreeNode *N) { } } - // FIXME: Only consider reloads for now. + // FIXME: Only consider reloads for now. We should be able to handle + // remat which does not have register operands. bool SkipCheck = false; int FI; if (SeenDef && !RuledOut) { |