diff options
| author | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2009-08-02 18:28:41 +0000 |
|---|---|---|
| committer | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2009-08-02 18:28:41 +0000 |
| commit | 0e6a4efdd4f97137fb0a58d7bb3de07562185530 (patch) | |
| tree | 930b5433486d25cd6bc6e5499a1110dd01ed8ecd | |
| parent | 6b30f5c86743a3386a14d15ad3faac8243b44c19 (diff) | |
Scavenger asserts.
Allow imp-def and imp-use of anything in the scavenger asserts, just like the machine code verifier.
Allow redefinition of a sub-register of a live register.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@77904 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | include/llvm/CodeGen/RegisterScavenging.h | 3 | ||||
| -rw-r--r-- | lib/CodeGen/RegisterScavenging.cpp | 13 | ||||
| -rw-r--r-- | test/CodeGen/Blackfin/load-intr.ll | 3 |
3 files changed, 14 insertions, 5 deletions
diff --git a/include/llvm/CodeGen/RegisterScavenging.h b/include/llvm/CodeGen/RegisterScavenging.h index 458c2e4487..fc75aea2bc 100644 --- a/include/llvm/CodeGen/RegisterScavenging.h +++ b/include/llvm/CodeGen/RegisterScavenging.h @@ -113,6 +113,9 @@ public: bool isUsed(unsigned Reg) const { return !RegsAvailable[Reg]; } bool isUnused(unsigned Reg) const { return RegsAvailable[Reg]; } + /// isSuperRegUsed - Test if a super register is currently being used. + bool isSuperRegUsed(unsigned Reg) const; + /// getRegsUsed - return all registers currently in use in used. void getRegsUsed(BitVector &used, bool includeReserved); diff --git a/lib/CodeGen/RegisterScavenging.cpp b/lib/CodeGen/RegisterScavenging.cpp index 972cf13a24..e32d23264d 100644 --- a/lib/CodeGen/RegisterScavenging.cpp +++ b/lib/CodeGen/RegisterScavenging.cpp @@ -57,6 +57,14 @@ static bool RedefinesSuperRegPart(const MachineInstr *MI, return RedefinesSuperRegPart(MI, MO.getReg(), TRI); } +bool RegScavenger::isSuperRegUsed(unsigned Reg) const { + for (const unsigned *SuperRegs = TRI->getSuperRegisters(Reg); + unsigned SuperReg = *SuperRegs; ++SuperRegs) + if (isUsed(SuperReg)) + return true; + return false; +} + /// setUsed - Set the register and its sub-registers as being used. void RegScavenger::setUsed(unsigned Reg) { RegsAvailable.reset(Reg); @@ -218,7 +226,7 @@ void RegScavenger::forward() { const MachineOperand MO = *UseMOs[i].first; unsigned Reg = MO.getReg(); - assert(isUsed(Reg) && "Using an undefined register!"); + assert((MO.isImplicit() || isUsed(Reg)) && "Using an undefined register!"); if (MO.isKill() && !isReserved(Reg)) { KillRegs.set(Reg); @@ -269,7 +277,8 @@ void RegScavenger::forward() { // Implicit def is allowed to "re-define" any register. Similarly, // implicitly defined registers can be clobbered. - assert((isReserved(Reg) || isUnused(Reg) || + assert((MO.isImplicit() || isReserved(Reg) || isUnused(Reg) || + isSuperRegUsed(Reg) || isLiveInButUnusedBefore(Reg, MI, MBB, TRI, MRI)) && "Re-defining a live register!"); setUsed(Reg); diff --git a/test/CodeGen/Blackfin/load-intr.ll b/test/CodeGen/Blackfin/load-intr.ll index 9d74237022..9ef8b978ac 100644 --- a/test/CodeGen/Blackfin/load-intr.ll +++ b/test/CodeGen/Blackfin/load-intr.ll @@ -1,7 +1,4 @@ ; RUN: llvm-as < %s | llc -march=bfin -verify-machineinstrs | FileCheck %s -; XFAIL: * -; Assertion failed: (isUsed(Reg) && "Using an undefined register!"), -; function forward, file lib/CodeGen/RegisterScavenging.cpp, line 221. define i16 @f(i32* %p) nounwind { entry: |