diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2009-06-30 12:18:16 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2009-06-30 12:18:16 +0000 |
| commit | f55715c5c70d2f762f7753707758650ac883f99e (patch) | |
| tree | 5dee5421469451efc98ae05e5db7cbdadb6660cd | |
| parent | 50564ebc9e3d7ff806062023e6511e91065df0d2 (diff) | |
Fix PR4484.
This was caused by me confounding FP0 and ST(0).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@74523 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Target/X86/X86FloatingPoint.cpp | 8 | ||||
| -rw-r--r-- | test/CodeGen/X86/inline-asm-fpstack4.ll | 15 |
2 files changed, 20 insertions, 3 deletions
diff --git a/lib/Target/X86/X86FloatingPoint.cpp b/lib/Target/X86/X86FloatingPoint.cpp index abacdb2f9b..c282dc0094 100644 --- a/lib/Target/X86/X86FloatingPoint.cpp +++ b/lib/Target/X86/X86FloatingPoint.cpp @@ -990,16 +990,18 @@ void FPS::handleSpecialFP(MachineBasicBlock::iterator &I) { } case X86::FpSET_ST0_32: case X86::FpSET_ST0_64: - case X86::FpSET_ST0_80: + case X86::FpSET_ST0_80: { + unsigned RegOnTop = getStackEntry(0); // FpSET_ST0_80 is generated by copyRegToReg for both function return // and inline assembly with the "st" constrain. In the latter case, - // it is possible for FP0 to be alive after this instruction. - if (!MI->killsRegister(X86::FP0)) { + // it is possible for ST(0) to be alive after this instruction. + if (!MI->killsRegister(X86::FP0 + RegOnTop)) { // Duplicate ST0 duplicateToTop(0, 7 /*temp register*/, I); } --StackTop; // "Forget" we have something on the top of stack! break; + } case X86::FpSET_ST1_32: case X86::FpSET_ST1_64: case X86::FpSET_ST1_80: diff --git a/test/CodeGen/X86/inline-asm-fpstack4.ll b/test/CodeGen/X86/inline-asm-fpstack4.ll new file mode 100644 index 0000000000..24a63537fc --- /dev/null +++ b/test/CodeGen/X86/inline-asm-fpstack4.ll @@ -0,0 +1,15 @@ +; RUN: llvm-as < %s | llc -march=x86 > %t +; PR4484 + +declare x86_fp80 @ceil() + +declare void @test(x86_fp80) + +define void @test2(x86_fp80 %a) { +entry: + %0 = call x86_fp80 @ceil() + call void asm sideeffect "fistpl $0", "{st},~{st}"(x86_fp80 %a) + call void @test(x86_fp80 %0) + ret void +} + |