aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Dunbar <daniel@zuster.org>2010-03-25 01:03:24 +0000
committerDaniel Dunbar <daniel@zuster.org>2010-03-25 01:03:24 +0000
commit7c3d45a03e64ac1b5b2ecdb7153989fd7cebfd2c (patch)
treed275ab0f475a75a7fbee115915851ba82dbcb205
parente9cfd685f5916a45e7cd36e51191cec16b02189d (diff)
MC: Eliminate MC{Fragment,{Section,Symbol}Data}::getAddress.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@99467 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--include/llvm/MC/MCAssembler.h17
-rw-r--r--lib/MC/MCAssembler.cpp16
2 files changed, 11 insertions, 22 deletions
diff --git a/include/llvm/MC/MCAssembler.h b/include/llvm/MC/MCAssembler.h
index 54c91a2cb5..51fb88bf33 100644
--- a/include/llvm/MC/MCAssembler.h
+++ b/include/llvm/MC/MCAssembler.h
@@ -57,6 +57,8 @@ public:
};
class MCFragment : public ilist_node<MCFragment> {
+ friend class MCAsmLayout;
+
MCFragment(const MCFragment&); // DO NOT IMPLEMENT
void operator=(const MCFragment&); // DO NOT IMPLEMENT
@@ -108,8 +110,6 @@ public:
//
// FIXME: This could all be kept private to the assembler implementation.
- uint64_t getAddress() const;
-
uint64_t getFileSize() const {
assert(FileSize != ~UINT64_C(0) && "File size not set!");
return FileSize;
@@ -390,6 +390,8 @@ public:
// we anticipate the fast path being through an MCAssembler, the only reason to
// keep it out is for API abstraction.
class MCSectionData : public ilist_node<MCSectionData> {
+ friend class MCAsmLayout;
+
MCSectionData(const MCSectionData&); // DO NOT IMPLEMENT
void operator=(const MCSectionData&); // DO NOT IMPLEMENT
@@ -469,12 +471,6 @@ public:
//
// FIXME: This could all be kept private to the assembler implementation.
- uint64_t getAddress() const {
- assert(Address != ~UINT64_C(0) && "Address not set!");
- return Address;
- }
- void setAddress(uint64_t Value) { Address = Value; }
-
uint64_t getSize() const {
assert(Size != ~UINT64_C(0) && "File size not set!");
return Size;
@@ -549,11 +545,6 @@ public:
uint64_t getOffset() const { return Offset; }
void setOffset(uint64_t Value) { Offset = Value; }
- uint64_t getAddress() const {
- assert(getFragment() && "Invalid getAddress() on undefined symbol!");
- return getFragment()->getAddress() + getOffset();
- }
-
/// @}
/// @name Symbol Attributes
/// @{
diff --git a/lib/MC/MCAssembler.cpp b/lib/MC/MCAssembler.cpp
index 4a5db8ce22..3fac6c8334 100644
--- a/lib/MC/MCAssembler.cpp
+++ b/lib/MC/MCAssembler.cpp
@@ -46,19 +46,22 @@ STATISTIC(ObjectBytes, "Number of emitted object file bytes");
/* *** */
uint64_t MCAsmLayout::getFragmentAddress(const MCFragment *F) const {
- return F->getAddress();
+ assert(F->getParent() && "Missing section()!");
+ return getSectionAddress(F->getParent()) + F->getOffset();
}
uint64_t MCAsmLayout::getSymbolAddress(const MCSymbolData *SD) const {
- return SD->getAddress();
+ assert(SD->getFragment() && "Invalid getAddress() on undefined symbol!");
+ return getFragmentAddress(SD->getFragment()) + SD->getOffset();
}
uint64_t MCAsmLayout::getSectionAddress(const MCSectionData *SD) const {
- return SD->getAddress();
+ assert(SD->Address != ~UINT64_C(0) && "Address not set!");
+ return SD->Address;
}
void MCAsmLayout::setSectionAddress(MCSectionData *SD, uint64_t Value) {
- SD->setAddress(Value);
+ SD->Address = Value;
}
/* *** */
@@ -78,11 +81,6 @@ MCFragment::MCFragment(FragmentType _Kind, MCSectionData *_Parent)
MCFragment::~MCFragment() {
}
-uint64_t MCFragment::getAddress() const {
- assert(getParent() && "Missing Section!");
- return getParent()->getAddress() + Offset;
-}
-
/* *** */
MCSectionData::MCSectionData() : Section(0) {}