diff options
author | Nick Lewycky <nicholas@mxc.ca> | 2008-01-27 18:35:00 +0000 |
---|---|---|
committer | Nick Lewycky <nicholas@mxc.ca> | 2008-01-27 18:35:00 +0000 |
commit | c837abee2fa6cdf75dcfbaf27d7c53613ec7ff7a (patch) | |
tree | cd02425f94b429186dcc75f361f4e60eeb963d90 | |
parent | d82375c1c43db7f823dd4660d3495e76566699e3 (diff) |
Be more careful modifying the use_list while also iterating through it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46417 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/Transforms/Scalar/LoopUnroll.cpp | 3 | ||||
-rw-r--r-- | test/Transforms/LoopUnroll/2007-11-05-Crash.ll | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/lib/Transforms/Scalar/LoopUnroll.cpp b/lib/Transforms/Scalar/LoopUnroll.cpp index ff2168ac8d..b514156a1a 100644 --- a/lib/Transforms/Scalar/LoopUnroll.cpp +++ b/lib/Transforms/Scalar/LoopUnroll.cpp @@ -365,8 +365,9 @@ bool LoopUnroll::unrollLoop(Loop *L, unsigned Count, unsigned Threshold) { // be updated specially after unrolling all the way. if (*BB != LatchBlock) for (Value::use_iterator UI = (*BB)->use_begin(), UE = (*BB)->use_end(); - UI != UE; ++UI) { + UI != UE;) { Instruction *UseInst = cast<Instruction>(*UI); + ++UI; if (isa<PHINode>(UseInst) && !L->contains(UseInst->getParent())) { PHINode *phi = cast<PHINode>(UseInst); Value *Incoming = phi->getIncomingValueForBlock(*BB); diff --git a/test/Transforms/LoopUnroll/2007-11-05-Crash.ll b/test/Transforms/LoopUnroll/2007-11-05-Crash.ll index a5e13d5a26..a46c09e3bd 100644 --- a/test/Transforms/LoopUnroll/2007-11-05-Crash.ll +++ b/test/Transforms/LoopUnroll/2007-11-05-Crash.ll @@ -1,5 +1,7 @@ ; RUN: llvm-as < %s | opt -disable-output -loop-unroll ; PR1770 +; PR1947 + %struct.cl_engine = type { i32, i16, i32, i8**, i8**, i8*, i8*, i8*, i8*, i8*, i8*, i8* } %struct.cl_limits = type { i32, i32, i32, i32, i16, i64 } %struct.cli_ac_alt = type { i8, i8*, i16, i16, %struct.cli_ac_alt* } |