diff options
| author | Sanjiv Gupta <sanjiv.gupta@microchip.com> | 2009-04-26 17:14:35 +0000 |
|---|---|---|
| committer | Sanjiv Gupta <sanjiv.gupta@microchip.com> | 2009-04-26 17:14:35 +0000 |
| commit | 9341c808ae684aeddcb4a926be3e3af62be22518 (patch) | |
| tree | 9c93e7b6daa166bd676e68022e6881ef08ad7e4e | |
| parent | efdb3bc8d058981d4d03771a839fd262d0e43172 (diff) | |
Any size of integral indices are allowed in gep for indexing into sequential types. Also adding a test case to check the indices type allowed into struct.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@70134 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | docs/LangRef.html | 2 | ||||
| -rw-r--r-- | lib/VMCore/Type.cpp | 5 | ||||
| -rw-r--r-- | test/Assembler/getelementptr_struct.ll | 12 |
3 files changed, 15 insertions, 4 deletions
diff --git a/docs/LangRef.html b/docs/LangRef.html index c07d0e0d59..313bf83347 100644 --- a/docs/LangRef.html +++ b/docs/LangRef.html @@ -3629,7 +3629,7 @@ the pointer before continuing calculation.</p> <p>The type of each index argument depends on the type it is indexing into. When indexing into a (packed) structure, only <tt>i32</tt> integer <b>constants</b> are allowed. When indexing into an array, pointer or vector, -only integers of 16, 32 or 64 bits are allowed (also non-constants). 16-bit +integers of any width are allowed (also non-constants). 16-bit values will be sign extended to 32-bits if required, and 32-bit values will be sign extended to 64-bits if required.</p> diff --git a/lib/VMCore/Type.cpp b/lib/VMCore/Type.cpp index c85395f620..4a53fcf6f8 100644 --- a/lib/VMCore/Type.cpp +++ b/lib/VMCore/Type.cpp @@ -1410,9 +1410,8 @@ void PointerType::typeBecameConcrete(const DerivedType *AbsTy) { } bool SequentialType::indexValid(const Value *V) const { - if (const IntegerType *IT = dyn_cast<IntegerType>(V->getType())) - return IT->getBitWidth() == 16 || IT->getBitWidth() == 32 || - IT->getBitWidth() == 64; + if (isa<IntegerType>(V->getType())) + return true; return false; } diff --git a/test/Assembler/getelementptr_struct.ll b/test/Assembler/getelementptr_struct.ll new file mode 100644 index 0000000000..c8779a6407 --- /dev/null +++ b/test/Assembler/getelementptr_struct.ll @@ -0,0 +1,12 @@ +; RUN: not llvm-as < %s >/dev/null |& grep {invalid getelementptr indices} +; Test the case of a incorrect indices type into struct + +%RT = type { i8 , [10 x [20 x i32]], i8 } +%ST = type { i32, double, %RT } + +define i32* @foo(%ST* %s) { +entry: + %reg = getelementptr %ST* %s, i32 1, i64 2, i32 1, i32 5, i32 13 + ret i32* %reg +} + |