diff options
author | Owen Anderson <resistor@mac.com> | 2007-07-30 21:26:39 +0000 |
---|---|---|
committer | Owen Anderson <resistor@mac.com> | 2007-07-30 21:26:39 +0000 |
commit | 891eecb040b26426fdb31499939eb1916ce6bf8d (patch) | |
tree | b4268c1a3676d4a735fd5cfb8acddd352ea5b851 | |
parent | df5cf2074c336fb4de7e5b77e7b3bbbf21948a53 (diff) |
Avoid potential iterator invalidation problems.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@40607 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/Transforms/Scalar/GVN.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/Transforms/Scalar/GVN.cpp b/lib/Transforms/Scalar/GVN.cpp index fee0eedcc7..42e9ee8900 100644 --- a/lib/Transforms/Scalar/GVN.cpp +++ b/lib/Transforms/Scalar/GVN.cpp @@ -895,11 +895,14 @@ bool GVN::runOnFunction(Function &F) { currAvail = availableOut[DI->getIDom()->getBlock()]; for (BasicBlock::iterator BI = BB->begin(), BE = BB->end(); - BI != BE; ++BI) { + BI != BE; ) { changed_function |= processInstruction(BI, currAvail, lastSeenLoad, toErase); NumGVNInstr += toErase.size(); + // Avoid iterator invalidation + ++BI; + for (SmallVector<Instruction*, 4>::iterator I = toErase.begin(), E = toErase.end(); I != E; ++I) (*I)->eraseFromParent(); |