llvm/tools/llvm-diff, branch release_31http://llvm.orghttps://git.amat.us/llvm/atom/tools/llvm-diff?h=release_312012-03-11T06:09:17Zllvm::SwitchInst2012-03-11T06:09:17ZStepan Dyatkovskiystpworld@narod.ru2012-03-11T06:09:17Zurn:sha1:3d3abe0852d5f499bed7ab014519dd582a0a795d
Renamed methods caseBegin, caseEnd and caseDefault with case_begin, case_end, and case_default.
Added some notes relative to case iterators.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@152532 91177308-0d34-0410-b5e6-96231b3b80d8
Taken into account Duncan's comments for r149481 dated by 2nd Feb 2012:2012-03-08T07:06:20ZStepan Dyatkovskiystpworld@narod.ru2012-03-08T07:06:20Zurn:sha1:c10fa6c801e48771b5eade50afc2fe6abaf08227
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120130/136146.html
Implemented CaseIterator and it solves almost all described issues: we don't need to mix operand/case/successor indexing anymore. Base iterator class is implemented as a template since it may be initialized either from "const SwitchInst*" or from "SwitchInst*".
ConstCaseIt is just a read-only iterator.
CaseIt is read-write iterator; it allows to change case successor and case value.
Usage of iterator allows totally remove resolveXXXX methods. All indexing convertions done automatically inside the iterator's getters.
Main way of iterator usage looks like this:
SwitchInst *SI = ... // intialize it somehow
for (SwitchInst::CaseIt i = SI->caseBegin(), e = SI->caseEnd(); i != e; ++i) {
BasicBlock *BB = i.getCaseSuccessor();
ConstantInt *V = i.getCaseValue();
// Do something.
}
If you want to convert case number to TerminatorInst successor index, just use getSuccessorIndex iterator's method.
If you want initialize iterator from TerminatorInst successor index, use CaseIt::fromSuccessorIndex(...) method.
There are also related changes in llvm-clients: klee and clang.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@152297 91177308-0d34-0410-b5e6-96231b3b80d8
SwitchInst refactoring.2012-02-01T07:49:51ZStepan Dyatkovskiystpworld@narod.ru2012-02-01T07:49:51Zurn:sha1:24473120a253a05f3601cd3373403b47e6d03d41
The purpose of refactoring is to hide operand roles from SwitchInst user (programmer). If you want to play with operands directly, probably you will need lower level methods than SwitchInst ones (TerminatorInst or may be User). After this patch we can reorganize SwitchInst operands and successors as we want.
What was done:
1. Changed semantics of index inside the getCaseValue method:
getCaseValue(0) means "get first case", not a condition. Use getCondition() if you want to resolve the condition. I propose don't mix SwitchInst case indexing with low level indexing (TI successors indexing, User's operands indexing), since it may be dangerous.
2. By the same reason findCaseValue(ConstantInt*) returns actual number of case value. 0 means first case, not default. If there is no case with given value, ErrorIndex will returned.
3. Added getCaseSuccessor method. I propose to avoid usage of TerminatorInst::getSuccessor if you want to resolve case successor BB. Use getCaseSuccessor instead, since internal SwitchInst organization of operands/successors is hidden and may be changed in any moment.
4. Added resolveSuccessorIndex and resolveCaseIndex. The main purpose of these methods is to see how case successors are really mapped in TerminatorInst.
4.1 "resolveSuccessorIndex" was created if you need to level down from SwitchInst to TerminatorInst. It returns TerminatorInst's successor index for given case successor.
4.2 "resolveCaseIndex" converts low level successors index to case index that curresponds to the given successor.
Note: There are also related compatability fix patches for dragonegg, klee, llvm-gcc-4.0, llvm-gcc-4.2, safecode, clang.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@149481 91177308-0d34-0410-b5e6-96231b3b80d8
Unweaken vtables as per http://llvm.org/docs/CodingStandards.html#ll_virtual_anch2011-12-20T02:50:00ZDavid Blaikiedblaikie@gmail.com2011-12-20T02:50:00Zurn:sha1:2d24e2a396a1d211baaeedf32148a3b657240170
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@146960 91177308-0d34-0410-b5e6-96231b3b80d8
LLVMBuild: Remove trailing newline, which irked me.2011-12-12T19:48:00ZDaniel Dunbardaniel@zuster.org2011-12-12T19:48:00Zurn:sha1:4ab406d7fc06b1272d02cd8be46f0c5ebe51a3da
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@146409 91177308-0d34-0410-b5e6-96231b3b80d8
LLVMBuild: Add description files for the LLVM tools.2011-11-11T22:59:39ZDaniel Dunbardaniel@zuster.org2011-11-11T22:59:39Zurn:sha1:0d3c223035d057101cb9d9dd5ecb4500fcb15085
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@144417 91177308-0d34-0410-b5e6-96231b3b80d8
Use isa<> instead of dyn_cast<> as suggested by Nick.2011-11-09T03:26:50ZJohn McCallrjmccall@apple.com2011-11-09T03:26:50Zurn:sha1:fd22883a345b2e04d0bdb4d4b9ed64ceebdc0601
Should've read the patch a bit closer, sorry.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@144164 91177308-0d34-0410-b5e6-96231b3b80d8
Fix the printing of constants. Patch by Stepan Dyatkovskiy!2011-11-08T06:53:04ZJohn McCallrjmccall@apple.com2011-11-08T06:53:04Zurn:sha1:bd3c5ecd37e760f0430c9cbd1fda5740eb7c0e27
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@144079 91177308-0d34-0410-b5e6-96231b3b80d8
build: Tidy up a bunch of tool Makefiles, and simplify where possible using the2011-10-18T19:27:24ZDaniel Dunbardaniel@zuster.org2011-10-18T19:27:24Zurn:sha1:8c39c9647da4f375e4f89bd417d86f5c3ff6dfa5
new all-targets pseudo-component.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@142401 91177308-0d34-0410-b5e6-96231b3b80d8
Enhance llvm::SourceMgr to support diagnostic ranges, the same way clang does. Enhance2011-10-16T04:47:35ZChris Lattnersabre@nondot.org2011-10-16T04:47:35Zurn:sha1:d8b7aa26134d2abee777f745c32005e63dea2455
the X86 asmparser to produce ranges in the one case that was annoying me, for example:
test.s:10:15: error: invalid operand for instruction
movl 0(%rax), 0(%edx)
^~~~~~~
It should be straight-forward to enhance filecheck, tblgen, and/or the .ll parser to use
ranges where appropriate if someone is interested.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@142106 91177308-0d34-0410-b5e6-96231b3b80d8