http://llvm.org https://git.amat.us/llvm/atom/lib/Bitcode/Writer?h=release_31 2012-03-11T06:09:17Z 2012-03-11T06:09:17Z Stepan Dyatkovskiy stpworld@narod.ru 2012-03-11T06:09:17Z urn:sha1:3d3abe0852d5f499bed7ab014519dd582a0a795d Renamed methods caseBegin, caseEnd and caseDefault with case_begin, case_end, and case_default. Added some notes relative to case iterators. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@152532 91177308-0d34-0410-b5e6-96231b3b80d8 2012-03-08T07:06:20Z Stepan Dyatkovskiy stpworld@narod.ru 2012-03-08T07:06:20Z urn:sha1:c10fa6c801e48771b5eade50afc2fe6abaf08227 http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120130/136146.html Implemented CaseIterator and it solves almost all described issues: we don't need to mix operand/case/successor indexing anymore. Base iterator class is implemented as a template since it may be initialized either from "const SwitchInst*" or from "SwitchInst*". ConstCaseIt is just a read-only iterator. CaseIt is read-write iterator; it allows to change case successor and case value. Usage of iterator allows totally remove resolveXXXX methods. All indexing convertions done automatically inside the iterator's getters. Main way of iterator usage looks like this: SwitchInst *SI = ... // intialize it somehow for (SwitchInst::CaseIt i = SI->caseBegin(), e = SI->caseEnd(); i != e; ++i) { BasicBlock *BB = i.getCaseSuccessor(); ConstantInt *V = i.getCaseValue(); // Do something. } If you want to convert case number to TerminatorInst successor index, just use getSuccessorIndex iterator's method. If you want initialize iterator from TerminatorInst successor index, use CaseIt::fromSuccessorIndex(...) method. There are also related changes in llvm-clients: klee and clang. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@152297 91177308-0d34-0410-b5e6-96231b3b80d8 2012-02-29T20:31:09Z Daniel Dunbar daniel@zuster.org 2012-02-29T20:31:09Z urn:sha1:acbceeae4d7bdfbbc3437c60a5a3e26449888a15 std::vector. - Good for 1-2% speedup on writing PCH for Cocoa.h. - Clang side API match to follow shortly, there wasn't an easy way to make this non-breaking. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@151750 91177308-0d34-0410-b5e6-96231b3b80d8 2012-02-29T20:31:01Z Daniel Dunbar daniel@zuster.org 2012-02-29T20:31:01Z urn:sha1:02a248afe310c86aea682302fc587f22bb999fa7 and remove getBuffer(). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@151748 91177308-0d34-0410-b5e6-96231b3b80d8 2012-02-29T20:30:56Z Daniel Dunbar daniel@zuster.org 2012-02-29T20:30:56Z urn:sha1:fdc8f785cd52a4438d5bf914594253b7787ab80e git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@151747 91177308-0d34-0410-b5e6-96231b3b80d8 2012-02-06T22:30:29Z Derek Schuff dschuff@google.com 2012-02-06T22:30:29Z urn:sha1:2ea93875b2f2900b9d244dfd7649c9ed02a34cd7 This CL delays reading of function bodies from initial parse until materialization, allowing overlap of compilation with bitcode download. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@149918 91177308-0d34-0410-b5e6-96231b3b80d8 2012-02-06T21:30:37Z Bill Wendling isanbard@gmail.com 2012-02-06T21:30:37Z urn:sha1:3e9719e1f3a7ba41abacb6e4155cfd71a7d9788f git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@149905 91177308-0d34-0410-b5e6-96231b3b80d8 2012-02-05T02:29:43Z Chris Lattner sabre@nondot.org 2012-02-05T02:29:43Z urn:sha1:18c7f80b3e83ab584bd8572695a3cde8bafd9d3c but with a critical fix to the SelectionDAG code that optimizes copies from strings into immediate stores: the previous code was stopping reading string data at the first nul. Address this by adding a new argument to llvm::getConstantStringInfo, preserving the behavior before the patch. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@149800 91177308-0d34-0410-b5e6-96231b3b80d8 2012-02-01T07:49:51Z Stepan Dyatkovskiy stpworld@narod.ru 2012-02-01T07:49:51Z urn:sha1:24473120a253a05f3601cd3373403b47e6d03d41 The purpose of refactoring is to hide operand roles from SwitchInst user (programmer). If you want to play with operands directly, probably you will need lower level methods than SwitchInst ones (TerminatorInst or may be User). After this patch we can reorganize SwitchInst operands and successors as we want. What was done: 1. Changed semantics of index inside the getCaseValue method: getCaseValue(0) means "get first case", not a condition. Use getCondition() if you want to resolve the condition. I propose don't mix SwitchInst case indexing with low level indexing (TI successors indexing, User's operands indexing), since it may be dangerous. 2. By the same reason findCaseValue(ConstantInt*) returns actual number of case value. 0 means first case, not default. If there is no case with given value, ErrorIndex will returned. 3. Added getCaseSuccessor method. I propose to avoid usage of TerminatorInst::getSuccessor if you want to resolve case successor BB. Use getCaseSuccessor instead, since internal SwitchInst organization of operands/successors is hidden and may be changed in any moment. 4. Added resolveSuccessorIndex and resolveCaseIndex. The main purpose of these methods is to see how case successors are really mapped in TerminatorInst. 4.1 "resolveSuccessorIndex" was created if you need to level down from SwitchInst to TerminatorInst. It returns TerminatorInst's successor index for given case successor. 4.2 "resolveCaseIndex" converts low level successors index to case index that curresponds to the given successor. Note: There are also related compatability fix patches for dragonegg, klee, llvm-gcc-4.0, llvm-gcc-4.2, safecode, clang. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@149481 91177308-0d34-0410-b5e6-96231b3b80d8 2012-02-01T04:51:17Z Argyrios Kyrtzidis akyrtzi@gmail.com 2012-02-01T04:51:17Z urn:sha1:91766fe066efe6e0969ba805a2e3726a70ed34a3 These are: r149348 r149351 r149352 r149354 r149356 r149357 r149361 r149362 r149364 r149365 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@149470 91177308-0d34-0410-b5e6-96231b3b80d8