From 542f491542b0312f8b28e17a013f6f8f114bda68 Mon Sep 17 00:00:00 2001 From: Julia Lawall Date: Fri, 11 Sep 2009 18:22:27 +0200 Subject: Staging: iio: introduce missing kfree Error handling code following a kmalloc or kzalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } ( x->f1 = E | (x->f1 == NULL || ...) | f(...,x->f1,...) ) ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // Signed-off-by: Julia Lawall --- drivers/staging/iio/accel/lis3l02dq_ring.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/accel/lis3l02dq_ring.c b/drivers/staging/iio/accel/lis3l02dq_ring.c index c21198d18c9..a6b7c72a86f 100644 --- a/drivers/staging/iio/accel/lis3l02dq_ring.c +++ b/drivers/staging/iio/accel/lis3l02dq_ring.c @@ -286,6 +286,7 @@ static void lis3l02dq_trigger_bh_to_ring(struct work_struct *work_s) rx_array = kmalloc(4 * (st->indio_dev->scan_count), GFP_KERNEL); if (rx_array == NULL) { dev_err(&st->us->dev, "memory alloc failed in ring bh"); + kfree(data); return; } -- cgit v1.2.3-18-g5258