From 40f5d72a4fc098c47068e3888cfb055922f6519f Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Thu, 7 Jul 2011 21:27:24 +0000 Subject: dcbnl: unlock on an error path in dcbnl_cee_fill() We need to release "dcb_lock" which we took on the previous line. Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller --- net/dcb/dcbnl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c index 6a015f211fe..3cb56af4e13 100644 --- a/net/dcb/dcbnl.c +++ b/net/dcb/dcbnl.c @@ -1409,7 +1409,7 @@ static int dcbnl_cee_fill(struct sk_buff *skb, struct net_device *netdev) spin_lock(&dcb_lock); app = nla_nest_start(skb, DCB_ATTR_CEE_APP_TABLE); if (!app) - goto nla_put_failure; + goto dcb_unlock; list_for_each_entry(itr, &dcb_app_list, list) { if (strncmp(itr->name, netdev->name, IFNAMSIZ) == 0) { -- cgit v1.2.3-18-g5258