From 02354e2daffe5ffed2b128824daf6eced0e13688 Mon Sep 17 00:00:00 2001 From: Alexey Dobriyan Date: Fri, 6 Feb 2009 00:30:05 +0300 Subject: seq_file: fix big-enough lseek() + read() commit f01d1d546abb2f4028b5299092f529eefb01253a upstream. lseek() further than length of the file will leave stale ->index (second-to-last during iteration). Next seq_read() will not notice that ->f_pos is big enough to return 0, but will print last item as if ->f_pos is pointing to it. Introduced in commit cb510b8172602a66467f3551b4be1911f5a7c8c2 aka "seq_file: more atomicity in traverse()". Signed-off-by: Alexey Dobriyan Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- fs/seq_file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/seq_file.c b/fs/seq_file.c index 9549b71737b..3404ec8269c 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c @@ -102,6 +102,7 @@ static int traverse(struct seq_file *m, loff_t offset) p = m->op->next(m, p, &index); } m->op->stop(m, p); + m->index = index; return error; Eoverflow: -- cgit v1.2.3-18-g5258