aboutsummaryrefslogtreecommitdiff
path: root/security
diff options
context:
space:
mode:
authorMarc Zyngier <maz@misterjones.org>2010-04-27 13:13:07 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2010-04-27 16:26:03 -0700
commita2cb9aeb3c9b2475955cec328487484034f414e4 (patch)
tree94ca8e8f602150cff3e6f98173c9377db165854c /security
parent3835541dd481091c4dbf5ef83c08aed12e50fd61 (diff)
gpio: fix pca953x set_type 'scheduling while atomic' bug
Bill Gatliff reported the following bug when using the irq_chip facility of the pca953x driver on a PPC platform: BUG: scheduling while atomic: insmod/1530/0x00000002 He traced it back to an i2c transaction in pca953x_irq_set_type(), which can be called with interrupt disabled (from __setup_irq()). As the i2c controller can sleep while sending a message, this qualifies as a bad idea. This patch moves the i2c transaction to pca953x_irq_bus_sync_unlock(), where it is actually safe to send an i2c message. [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: Marc Zyngier <maz@misterjones.org> Reported-by: Bill Gatliff <bgat@billgatliff.com> Cc: Eric Miao <eric.y.miao@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions