aboutsummaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorApollon Oikonomopoulos <apollon@noc.grnet.gr>2010-12-07 09:43:30 +0000
committerGreg Kroah-Hartman <gregkh@suse.de>2011-03-21 12:45:04 -0700
commit267be76c7ce0edf9e443c0654786bf2221dcadd6 (patch)
tree344c5ae707aeae521155cb4d5706c1e5c6495d28 /net
parent5aab0d7a20e4dca3268888c81ffa960531388347 (diff)
x25: decrement netdev reference counts on unload
commit 171995e5d82dcc92bea37a7d2a2ecc21068a0f19 upstream. x25 does not decrement the network device reference counts on module unload. Thus unregistering any pre-existing interface after unloading the x25 module hangs and results in unregister_netdevice: waiting for tap0 to become free. Usage count = 1 This patch decrements the reference counts of all interfaces in x25_link_free, the way it is already done in x25_link_device_down for NETDEV_DOWN events. Signed-off-by: Apollon Oikonomopoulos <apollon@noc.grnet.gr> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'net')
-rw-r--r--net/x25/x25_link.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/x25/x25_link.c b/net/x25/x25_link.c
index e4e1b6e4953..8954783597c 100644
--- a/net/x25/x25_link.c
+++ b/net/x25/x25_link.c
@@ -393,6 +393,7 @@ void __exit x25_link_free(void)
list_for_each_safe(entry, tmp, &x25_neigh_list) {
nb = list_entry(entry, struct x25_neigh, node);
__x25_remove_neigh(nb);
+ dev_put(nb->dev);
}
write_unlock_bh(&x25_neigh_list_lock);
}