diff options
| author | Sascha Hlusiak <contact@saschahlusiak.de> | 2009-09-29 11:27:05 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-04-01 15:52:19 -0700 |
| commit | f02363178930a9fb73c88f88c3c347d27d62a082 (patch) | |
| tree | 37c47c9caafe2cae7bf687309d1df1aaf6e0a4b0 /net/ipv6 | |
| parent | 140d894f72c42b58de16c7587241fdd369fc81da (diff) | |
sit: fix off-by-one in ipip6_tunnel_get_prl
commit 298bf12ddb25841804f26234a43b89da1b1c0e21 upstream.
When requesting all prl entries (kprl.addr == INADDR_ANY) and there are
more prl entries than there is space passed from userspace, the existing
code would always copy cmax+1 entries, which is more than can be handled.
This patch makes the kernel copy only exactly cmax entries.
Signed-off-by: Sascha Hlusiak <contact@saschahlusiak.de>
Acked-By: Fred L. Templin <Fred.L.Templin@boeing.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'net/ipv6')
| -rw-r--r-- | net/ipv6/sit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c index b7a50e96850..0a913c9900d 100644 --- a/net/ipv6/sit.c +++ b/net/ipv6/sit.c @@ -260,7 +260,7 @@ static int ipip6_tunnel_get_prl(struct ip_tunnel *t, c = 0; for (prl = t->prl; prl; prl = prl->next) { - if (c > cmax) + if (c >= cmax) break; if (kprl.addr != htonl(INADDR_ANY) && prl->addr != kprl.addr) continue; |