diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2009-10-30 05:03:53 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-10-30 12:25:12 -0700 |
| commit | 9d410c796067686b1e032d54ce475b7055537138 (patch) | |
| tree | 4442bdbe4a4be1cce024f2e83a12b7404ef935fa /net/ipv6/udp.c | |
| parent | 63ca2d74ea4f9c7a7ac082c915609a7b224908e7 (diff) | |
net: fix sk_forward_alloc corruption
On UDP sockets, we must call skb_free_datagram() with socket locked,
or risk sk_forward_alloc corruption. This requirement is not respected
in SUNRPC.
Add a convenient helper, skb_free_datagram_locked() and use it in SUNRPC
Reported-by: Francis Moreau <francis.moro@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/udp.c')
| -rw-r--r-- | net/ipv6/udp.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index 3a60f12b34e..cf538ed5ef6 100644 --- a/net/ipv6/udp.c +++ b/net/ipv6/udp.c @@ -288,9 +288,7 @@ try_again: err = ulen; out_free: - lock_sock(sk); - skb_free_datagram(sk, skb); - release_sock(sk); + skb_free_datagram_locked(sk, skb); out: return err; |