diff options
author | Peter Hurley <peter@hurleysoftware.com> | 2011-08-05 10:44:21 -0400 |
---|---|---|
committer | Gustavo F. Padovan <padovan@profusion.mobi> | 2011-08-11 19:50:27 -0300 |
commit | 7176522cdca1f0b78a1434b41761f0334511822a (patch) | |
tree | 58ec3c3fc712536e898bd2d7780361e8a492f22a /net/bluetooth/cmtp/cmtp.h | |
parent | 751c10a56802513a6b057c8cf1552cecc1c9afde (diff) |
Bluetooth: cmtp: Fix deadlock in session deletion
Commit fada4ac339 introduced the usage of kthread API.
kthread_stop is a blocking function which returns only when
the thread exits. In this case, the thread can't exit because it's
waiting for the write lock, which is being held by cmtp_del_connection()
which is waiting for the thread to exit -- deadlock.
Revert cmtp_reset_ctr to its original behavior: non-blocking signalling
for the session to terminate.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
Diffstat (limited to 'net/bluetooth/cmtp/cmtp.h')
-rw-r--r-- | net/bluetooth/cmtp/cmtp.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/bluetooth/cmtp/cmtp.h b/net/bluetooth/cmtp/cmtp.h index db43b54ac9a..c32638dddbf 100644 --- a/net/bluetooth/cmtp/cmtp.h +++ b/net/bluetooth/cmtp/cmtp.h @@ -81,6 +81,7 @@ struct cmtp_session { char name[BTNAMSIZ]; + atomic_t terminate; struct task_struct *task; wait_queue_head_t wait; |