diff options
| author | Latchesar Ionkov <lucho@ionkov.net> | 2009-04-05 16:26:41 -0500 |
|---|---|---|
| committer | Eric Van Hensbergen <ericvh@vTrogdor.(none)> | 2009-04-05 16:54:52 -0500 |
| commit | 742b11a7ec60faa25d76c95c268041ab215c25ad (patch) | |
| tree | 86305d4b295f859d89fedd27a5f54ad8b029e5c3 /net/9p | |
| parent | 453ed90d1395a5281a8f1a0de5d8aabc66202e34 (diff) | |
net/9p: return error when p9_client_stat fails
p9_client_stat function doesn't return correct value if it fails.
p9_client_stat should return ERR_PTR of the error value when it fails.
Instead, it always returns a value to the allocated p9_wstat struct even
when it is not populated correctly.
This patch makes p9_client_stat to handle failure correctly.
Signed-off-by: Latchesar Ionkov <lucho@ionkov.net>
Reviewed-by: Eric Van Hensbergen <ericvh@gmail.com>
Diffstat (limited to 'net/9p')
| -rw-r--r-- | net/9p/client.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/net/9p/client.c b/net/9p/client.c index 93f442aaa11..781d89a952e 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -1244,10 +1244,14 @@ struct p9_wstat *p9_client_stat(struct p9_fid *fid) ret->name, ret->uid, ret->gid, ret->muid, ret->extension, ret->n_uid, ret->n_gid, ret->n_muid); + p9_free_req(clnt, req); + return ret; + free_and_error: p9_free_req(clnt, req); error: - return ret; + kfree(ret); + return ERR_PTR(err); } EXPORT_SYMBOL(p9_client_stat); |